Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Track unmodified methods and warn on unexpected/missing methods for important classes #75

Open
CursedFlames opened this issue Jan 4, 2022 · 0 comments
Labels
Enhancement New feature or request

Comments

@CursedFlames
Copy link
Member

In order to mitigate possible issues with us missing changes in future minecraft updates, in our ASM transformations we may want to track unmodified methods as well as transformed ones. We could then detect when there are missing methods, or untransformed methods that aren't in this list, indicating new methods.

Doing this for every class would be excessive, but doing it for some of the important classes (Level, ClientLevel, ServerLevel, LevelChunk etc.) could help us catch bugs while updating to new minecraft versions.

Once our ASM transformations are data-driven, this could, for example, take the form of an extra array of untransformed method names for each important class.

@CursedFlames CursedFlames added the Enhancement New feature or request label Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant