New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thirdparty and projects #91

Open

ghutchis opened this issue Apr 29, 2022 · 7 comments

Member

ghutchis commented Apr 29, 2022 •

edited

Loading

It would be good to have a regular cadence for updating dependencies.

zlib-ng instead of zlib: https://github.com/zlib-ng/zlib-ng
~~nlohmann JSON~~
~~Pybind11~~
etc.

varunseth578 commented May 5, 2023

In repository i checked zlib is present but where it we have to change
To zlib-ng?
Can you please help

Member Author

ghutchis commented May 9, 2023

You want to look in:
https://github.com/OpenChemistry/openchemistry/blob/master/cmake/External_zlib.cmake
https://github.com/OpenChemistry/openchemistry/blob/master/cmake/projects.cmake

MahirPatel3130 commented Sep 30, 2023

is this issue still opened ?

MahirPatel3130 commented Sep 30, 2023

aditya270520 commented Oct 13, 2023

is this issue open

Member Author

ghutchis commented Oct 16, 2023

If the issue were resolved, we would have closed the issue.

Yes, it would be nice to switch External_zlib and projects.cmake to zlib-ng instead.

Contributor

matterhorn103 commented Oct 29, 2024

Can we rename this issue so that it's purely for a zlib > zlib-ng port and open a new issue for a new round of routine dependency updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment