Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relative energies for 3dSets #19

Open
ghutchis opened this issue Sep 5, 2022 · 3 comments
Open

Clarify relative energies for 3dSets #19

ghutchis opened this issue Sep 5, 2022 · 3 comments

Comments

@ghutchis
Copy link
Member

ghutchis commented Sep 5, 2022

When creating 3dSets (e.g., conformers, molecular dynamics, following an optimization or IRC) it is useful to retain multiple properties - particularly relative energies.

It's not clear the best way to do handle this.

@ghutchis
Copy link
Member Author

After some thought, I'd like to nest this in properties:

'properties': {
    'totalCharge': 0,
    'spinMultiplicity': 1,
    'sets': {
        'totalEnergies': [ … ]
    }
}

This mirrors sets in orbitals and 3dsets in coords

@ghutchis
Copy link
Member Author

Thoughts @cryos ? - I'd like to implement this soon (to enable conformers)

@ghutchis
Copy link
Member Author

I was actually thinking about how to implement this, and I'd much rather have this second option:

'properties': {
    'totalCharge': 0,
    'spinMultiplicity': 1,
    'energies': [ … ]
}

The difference is that if we avoid nested objects (dictionaries, maps) in properties the parsing code just handles properties as one key/value store (e.g. energies is an array of numbers).

Thus properties would be a VariantMap for Avogadro:

  • booleans
  • numbers
  • strings
  • numeric arrays
  • 2D matrices (e.g., polarizabilities or lists of numeric arrays)

The schema can then specify a few well-defined keys (e.g., totalCharge, spinMultiplicity, energies, totalEnergy, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant