Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Summary By Partial Function bar graph #34

Open
simonredfern opened this issue Oct 23, 2017 · 2 comments
Open

In Summary By Partial Function bar graph #34

simonredfern opened this issue Oct 23, 2017 · 2 comments
Assignees

Comments

@simonredfern
Copy link
Member

... clicking on the name of partial function should take the user back to the list view and only show the calls to that partial function (with other search criteria still there).

This would allow us to see the details related to that call e.g. response codes etc.

@sebtesobe
Copy link
Contributor

Alas, http://www.chartjs.org/ does not allow for links in labels. Somebody at https://stackoverflow.com/questions/23631170/html-in-chart-js-labels pointed out that (older versions of) ChartJS uses SVG's fillText which outputs text verbatim. Maybe they could implement links, but that looks clunky to me in SVG: https://www.w3.org/wiki/SVG_Links . Maybe it is possible to modify the rendered SVG via some sort of DOM, but my browser does not show the elements after the SVG has been rendered.

Using another tool for drawing bar charts might do it, e.g. D3. But that is considerably more difficult to use than ChartJS for a 'simple' chart. I also do not know yet if D3 would be up to the task.

Then i tried to have empty labels in the chart and added HTML 'labels' positioned meticulously to appear in front of the bar. This positioning falls apart for different numbers of partial functions when using static margins in CSS. We would need some formula to calculate the values dynamically via JS. Also, responsiveness went over board, maybe fixable via JS. Meh ...

Maybe we need to think about the layout differently. We could draw one SVG bar chart for each partial function (without label) and have an HTML label with the link underneath each of them. This way we would have the bars still close together for comparison in size and have the links close to the corresponding bar.

Or maybe we ditch SVG / ChartJS altogether and draw using HTML only? We would lose a few special effects, but maybe we do not need all that eye-candy?

What do you reckon @simonredfern ?

@sebtesobe sebtesobe assigned simonredfern and sebtesobe and unassigned sebtesobe Oct 24, 2017
@simonredfern
Copy link
Member Author

I think more navigation functionality is better than eye candy - but not high prioirty right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants