Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time offset calculation in dllknode_setupSyncPhase() seems odd. #388

Open
borchehq opened this issue Jun 29, 2022 · 0 comments
Open

Time offset calculation in dllknode_setupSyncPhase() seems odd. #388

borchehq opened this issue Jun 29, 2022 · 0 comments

Comments

@borchehq
Copy link

Hi,

I was looking inside the function dllknode_setupSyncPhase (dllknode.c) and found the calculation of the transmission times of the Managing Node to be odd.
It seems as if the function doesn't account for neither the message length (Ethernet frame size of the PRes-message) of the Controlled Node next in line nor the message length of the PReq-message sent before when calculating the begin of transmission of the next PReq sent by the Managing Node.

Am I missing something important?

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant