Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions: Make sure precommit hook was run #226

Open
odscjames opened this issue Dec 14, 2022 · 1 comment
Open

Github Actions: Make sure precommit hook was run #226

odscjames opened this issue Dec 14, 2022 · 1 comment
Labels
Build This issue relates to the build process
Milestone
Minor: Build changes

Comments

@odscjames
Copy link
Collaborator

Split out from #19

Note if we use https://pre-commit.ci/ this should be easy. #225
@duncandewhurst duncandewhurst added the Build This issue relates to the build process label Dec 16, 2022
@odscjames odscjames mentioned this issue Dec 20, 2022
Open
odscjames added a commit that referenced this issue Dec 20, 2022
@odscjames
Add Precommit test
f287ee6 
#226
@odscjames odscjames mentioned this issue Dec 20, 2022
Merged
@odscjames
Copy link
Collaborator Author

We now have a very quick and basic test with "git diff" in. It's much better than nothing (which is what we previously had!), but it won't catch new files, so lets leave this issue open to work on that.

@duncandewhurst duncandewhurst added this to the Minor: Build changes milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build This issue relates to the build process
Projects
None yet
Milestone
Minor: Build changes
Development

No branches or pull requests
2 participants
@duncandewhurst @odscjames