-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple network providers #79
Comments
Changes are now released as 0.2 |
Ok I have a WIP. #82 applies to it, but that applied before so .... Here's some test data:
|
Tested on http://openfibrecove-2023-01-12.dokkudev2.ods.mobi/data/60abb6f6-147a-4050-bab5-8620c7b60a97 and looks good! Reminder that this will need doing for spans, too. |
Should already been done, just haven't made the test data yet |
Wasn't changed in popups - now done. @duncandewhurst can you test and if happy give that PR to @Bjwebb ? Data:
|
Closing as the related PR is merged and deployed. |
Open-Telecoms-Data/open-fibre-data-standard#234 makes the following changes to the schema:
Node.networkProvider
(anOrganisationReference
object) withNode.networkProviders
(an array ofOrganisationReference
objects)Span.networkProvider
(anOrganisationReference
object) withSpan.networkProviders
(an array ofOrganisationReference
objects)The map visualisation needs updating for the equivalent changes to the GeoJSON publication format:
nodes.geojson
:features/properties/networkProvider
(object) ->features/properties/networkProviders
(array)spans.geojson
:features/properties/networkProvider
(object) ->features/properties/networkProviders
(array)Open-Telecoms-Data/open-fibre-data-standard#210 describes a few options for handling multiple network providers in the map visualisation. I think that we want to go with the first option: Categorise according to the set of network providers, e.g.
[{"name": "Org A"}]
: Red[{"name": "Org B"}]
: Blue[{"name": "Org A"}, {"name": "Org B"}]
: Green[{"name": "Org B"}, {"name": "Org A"}]
: GreenThe changes are not yet released, but you can use the schema and example files from
0.2-dev
for development and testing.The text was updated successfully, but these errors were encountered: