[Dev] Enable compile TypeScript checks; noUnusedLocals, noUnusedParameters, & strictFunctionTypes

[jkasten2]

Description

One-Line Summary

Enforce some additional Typescript compile errors that were only IDE warnings.

Details

Enable these TS config compile settings. noUnusedLocals, noUnusedParameters, & strictFunctionTypes

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

[shepherd-l]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @emawby, @jkasten2, and @rgomezp)

---

src/shared/utils/Encoding.ts line 83 at r3 (raw file):

    encodeURIComponent(str).replace(
      /%([0-9A-F]{2})/g,
      function toSolidBytes(_match, p1) {

Should we just remove the method instead? Both base64Encode() and base64Decode()
I don't see them being referenced anywhere and the methods don't look like this in the docs referenced in the comment above: https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding

[jkasten2]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @emawby, @rgomezp, and @shepherd-l)

---

src/shared/utils/Encoding.ts line 83 at r3 (raw file):

Previously, shepherd-l (Shepherd) wrote…

Should we just remove the method instead? Both base64Encode() and base64Decode()
I don't see them being referenced anywhere and the methods don't looking like this in the docs referenced above today: https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding

ah good call, didn't look into the usage when I made the change. I confirmed they are not used and just made a commit here ot remove them in this PR.