-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Types to NPM #484
Comments
Why was this closed? |
It would also help to export I can install this SDK directly via Github in my package.json (I know this is discouraged but I just need the typings):
The following deep import successfully brings code completion and type checking to VS Code:
But it causes TypeScript to check the complete onesignal-web-sdk and throws multiple errors on compile (probably due to tsconfig differences in my project) even with @rgomezp Can anybody reopen this or reconsider a solution to make typings available? |
I'm happy to support this, although it may take some time to get around to. I'll need to confer with the team on the best approach here (DefinitelyTyped, bundled, inline, etc). |
@sherwinski Happy to read someone's taking care of this. May I just add that it would be helpful to publish the types whenever a new version is deployed to the OneSignal servers or if you go for "inline" at least tag a release with "stable" as "latest" might not exactly match the version loaded via CDN. Thank you |
Can you publish the typings here to DefinitelyTyped? Onesignal Cordova SDK is already in there.
The text was updated successfully, but these errors were encountered: