Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing Default implementations with a Black trait or similar #324

Open
Ogeon opened this issue Apr 29, 2023 · 0 comments
Open
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Milestone

Comments

@Ogeon
Copy link
Owner

Ogeon commented Apr 29, 2023

Description

Replace the current Default implementations with more "regular" versions that just sets the component values to their defaults. There should rather be a trait, such as Black (and White), or constants for the current use, to make the intent more explicit.

Motivation

The current Default implementations require more than just Default from the component values and the semantics get a bit weird with struct-of-arrays values. Separating the "default value" and "black color" concepts would make this less ambiguous.

@Ogeon Ogeon added the definitely breaking Issues that are known before-hand to be a breaking change label Apr 29, 2023
@Ogeon Ogeon added this to the 0.7.7 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant