Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out the Scalar from Premultiply to allow PreAlpha<&T> and more #319

Open
Ogeon opened this issue Apr 23, 2023 · 0 comments
Open

Split out the Scalar from Premultiply to allow PreAlpha<&T> and more #319

Ogeon opened this issue Apr 23, 2023 · 0 comments
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Milestone

Comments

@Ogeon
Copy link
Owner

Ogeon commented Apr 23, 2023

Description

Create a separate trait (Premultiplied? Something more generic?) with only the Scalar type that both Premultiply and PreAlpha can depend on. This is breaking because it (re)moves an associated type and changes the requirements.

Motivation

Separating the operation of premultiplying from the requirements for being in PreAlpha allows us to construct PreAlpha<&T>, PreAlpha<&mut T>, PreAlpha<&mut [T]> and so on, without having to allow them to be alpha unmasked. This is useful for struct-of-arrays algorithms, among other things.

@Ogeon Ogeon added the definitely breaking Issues that are known before-hand to be a breaking change label Apr 23, 2023
@Ogeon Ogeon added this to the 0.8.0 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
definitely breaking Issues that are known before-hand to be a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant