Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default branch was changed but not in ARM template #776

Closed
Mikhail2k15 opened this issue Jun 19, 2022 · 3 comments
Closed

The default branch was changed but not in ARM template #776

Mikhail2k15 opened this issue Jun 19, 2022 · 3 comments
Labels
answered Answered to the customer, waiting for confirmation

Comments

@Mikhail2k15
Copy link
Contributor

You renamed the default branch last Friday but didn't do the same in ARM templates. You'll have a version hell. Please take a look at this PR #775

@ghost ghost added the Needs: triage 🔍 label Jun 19, 2022
@v-royavinash
Copy link
Contributor

Thanks @Mikhail2k15 for highlighting this.

The branch name was updated and auto approve with one of the PRs. We have an upcoming PR which is under testing which will update all files with main as default branch. For now, main and master both works and doesn't break during deployment. We will confirm same post our testing.

@Mikhail2k15
Copy link
Contributor Author

IMO You have to merge this PR #775 ASAP in other case you will have versioning hell. For those who is trying to deploy now will have 2 commit behind from the current.

@Porkai-Pandian Porkai-Pandian added answered Answered to the customer, waiting for confirmation and removed Needs: triage 🔍 labels Jun 23, 2022
@Porkai-Pandian
Copy link
Collaborator

Hi @Mikhail2k15, this was taken care with the PR, hence marking this issue as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Answered to the customer, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants