From 11872cb01d5643c4af6e53fb4af4ac5e9a3987d6 Mon Sep 17 00:00:00 2001 From: Mischa ter Smitten Date: Tue, 5 Nov 2024 12:17:13 +0100 Subject: [PATCH 1/3] Add support for Noble --- .github/workflows/ci.yml | 14 ++++++------ Vagrantfile | 39 +++++++++++++++++++------------- meta/main.yml | 9 ++++---- molecule/default/collections.yml | 6 +---- molecule/default/molecule.yml | 2 +- 5 files changed, 37 insertions(+), 33 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7e2bc34..70e6297 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -44,14 +44,14 @@ jobs: fail-fast: false matrix: include: - - distro: debian8 - - distro: debian9 - distro: debian10 - - distro: ubuntu1604 - ansible-version: '>=2.10, <2.11' - - distro: ubuntu1604 + - distro: debian11 + - distro: debian12 - distro: ubuntu1804 + ansible-version: '>=9, <10' - distro: ubuntu2004 + - distro: ubuntu2204 + - distro: ubuntu2404 steps: - name: Check out the codebase @@ -65,8 +65,8 @@ jobs: python-version: '3.x' - name: Install test dependencies - run: pip install 'ansible${{ matrix.ansible-version }}' molecule-plugins[docker] docker - + run: | + pip install 'ansible${{ matrix.ansible-version }}' molecule-plugins[docker] docker - name: Run Molecule tests run: | molecule test diff --git a/Vagrantfile b/Vagrantfile index a0182a0..e86d32d 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -4,13 +4,6 @@ role = File.basename(File.expand_path(File.dirname(__FILE__))) boxes = [ - { - :name => "ubuntu-1604", - :box => "bento/ubuntu-16.04", - :ip => '10.0.0.12', - :cpu => "50", - :ram => "256" - }, { :name => "ubuntu-1804", :box => "bento/ubuntu-18.04", @@ -23,21 +16,21 @@ boxes = [ :box => "bento/ubuntu-20.04", :ip => '10.0.0.14', :cpu => "50", - :ram => "384" + :ram => "512" }, { - :name => "debian-8", - :box => "bento/debian-8", - :ip => '10.0.0.16', + :name => "ubuntu-2204", + :box => "bento/ubuntu-22.04", + :ip => '10.0.0.15', :cpu => "50", - :ram => "256" + :ram => "512" }, { - :name => "debian-9", - :box => "bento/debian-9", - :ip => '10.0.0.17', + :name => "ubuntu-2404", + :box => "bento/ubuntu-24.04", + :ip => '10.0.0.16', :cpu => "50", - :ram => "256" + :ram => "512" }, { :name => "debian-10", @@ -46,6 +39,20 @@ boxes = [ :cpu => "50", :ram => "256" }, + { + :name => "debian-11", + :box => "bento/debian-11", + :ip => '10.0.0.19', + :cpu => "50", + :ram => "256" + }, + { + :name => "debian-12", + :box => "bento/debian-12", + :ip => '10.0.0.20', + :cpu => "50", + :ram => "384" + }, ] Vagrant.configure("2") do |config| diff --git a/meta/main.yml b/meta/main.yml index df28125..519065f 100644 --- a/meta/main.yml +++ b/meta/main.yml @@ -4,20 +4,21 @@ galaxy_info: author: oefenweb role_name: maven company: Oefenweb.nl B.V. - description: Set up Apache Ant + description: Set up Apache Maven license: MIT min_ansible_version: 2.10.0 platforms: - name: Ubuntu versions: - - xenial - bionic - focal + - jammy + - noble - name: Debian versions: - - jessie - - stretch - buster + - bullseye + - bookworm galaxy_tags: - development - system diff --git a/molecule/default/collections.yml b/molecule/default/collections.yml index c3d7e2a..1062b36 100644 --- a/molecule/default/collections.yml +++ b/molecule/default/collections.yml @@ -1,6 +1,2 @@ --- -collections: - - name: community.docker - version: '>=1.2.0,<2' - - name: community.general - version: '>=2,<3' +collections: [] diff --git a/molecule/default/molecule.yml b/molecule/default/molecule.yml index 8841165..908aaf6 100644 --- a/molecule/default/molecule.yml +++ b/molecule/default/molecule.yml @@ -5,7 +5,7 @@ driver: name: docker platforms: - name: instance - image: "geerlingguy/docker-${MOLECULE_DISTRO:-ubuntu1604}-ansible:latest" + image: "geerlingguy/docker-${MOLECULE_DISTRO:-ubuntu2004}-ansible:latest" command: ${MOLECULE_DOCKER_COMMAND:-""} volumes: - /sys/fs/cgroup:/sys/fs/cgroup:rw From afc6e3b18e1894831dda616852a6284c033a8e89 Mon Sep 17 00:00:00 2001 From: Mischa ter Smitten Date: Tue, 5 Nov 2024 12:21:20 +0100 Subject: [PATCH 2/3] Fix failing download --- README.md | 2 +- defaults/main.yml | 2 +- tasks/main.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 3347a76..56a519c 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ None #### Variables -* `maven_version` [default: `3.9.5`]: Version to install +* `maven_version` [default: `3.9.9`]: Version to install * `maven_install_prefix` [default: `/opt`]: Install prefix ## Dependencies diff --git a/defaults/main.yml b/defaults/main.yml index ce55844..0f55aab 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -1,4 +1,4 @@ # defaults file --- -maven_version: 3.9.5 +maven_version: 3.9.0 maven_install_prefix: /opt diff --git a/tasks/main.yml b/tasks/main.yml index c4a078d..61ceec6 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -14,7 +14,7 @@ - name: download ansible.builtin.get_url: - url: "http://apache.cs.uu.nl/maven/maven-{{ maven_version.split('.')[0] }}/{{ maven_version }}/binaries/apache-maven-{{ maven_version }}-bin.tar.gz" + url: "https://dlcdn.apache.org/maven/maven-{{ maven_version.split('.')[0] }}/{{ maven_version }}/binaries/apache-maven-{{ maven_version }}-bin.tar.gz" dest: "{{ maven_downloads_path }}/apache-maven-{{ maven_version }}-bin.tar.gz" owner: root group: root From 2337c2ed3397e6d048ff8a23dc6a36f69dcd1d78 Mon Sep 17 00:00:00 2001 From: Mischa ter Smitten Date: Tue, 5 Nov 2024 12:29:17 +0100 Subject: [PATCH 3/3] Fix typo --- defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/main.yml b/defaults/main.yml index 0f55aab..11be06a 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -1,4 +1,4 @@ # defaults file --- -maven_version: 3.9.0 +maven_version: 3.9.9 maven_install_prefix: /opt