From 646514f1ec597770b15f6ac3fed9235893ab75db Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 10:55:23 +1000 Subject: [PATCH 1/7] always collect --- build/Build.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/build/Build.cs b/build/Build.cs index 4b733c43..21ed932f 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -112,6 +112,7 @@ ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target depe .EnableNoBuild() .EnableNoRestore() .EnableBlameCrash() + .EnableBlameCrashCollectAlways() // Lets make sure we can collect them. .SetBlameCrashDumpType("full") .EnableBlameHang() .SetBlameHangTimeout(TimeSpan.FromMinutes(20).TotalMilliseconds.ToString()) From 663bd6786e3ad7edbdbcf79a54ad30dcbca0073b Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 10:56:07 +1000 Subject: [PATCH 2/7] . --- .../Support/TestCases/ClientAndServiceTestCasesBuilder.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs index b3c0274d..c29ebd0b 100644 --- a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs +++ b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs @@ -42,18 +42,21 @@ public IEnumerable Build() if (!forceClientProxyTypes.Any()) { yield return new ClientAndServiceTestCase(serviceConnectionType, networkConditionTestCase, recommendedIterations, clientServiceTestVersion, null); + yield break; } else { if (clientServiceTestVersion.IsPreviousClient()) { yield return new ClientAndServiceTestCase(serviceConnectionType, networkConditionTestCase, recommendedIterations, clientServiceTestVersion, null); + yield break; } else { foreach (var forceClientProxyType in forceClientProxyTypes) { yield return new ClientAndServiceTestCase(serviceConnectionType, networkConditionTestCase, recommendedIterations, clientServiceTestVersion, forceClientProxyType); + yield break; } } } From 6f89fe68b4d76f6f1ab1f85165c113ff98d227fa Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 11:05:31 +1000 Subject: [PATCH 3/7] . --- .../Support/TestCases/ClientAndServiceTestCasesBuilder.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs index c29ebd0b..cded718e 100644 --- a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs +++ b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs @@ -1,3 +1,4 @@ +using System; using System.Collections.Generic; using System.Linq; using Halibut.Tests.Util; @@ -42,6 +43,7 @@ public IEnumerable Build() if (!forceClientProxyTypes.Any()) { yield return new ClientAndServiceTestCase(serviceConnectionType, networkConditionTestCase, recommendedIterations, clientServiceTestVersion, null); + Environment.Exit(-1); yield break; } else From 1ef9094fdc40737a1ea896728e4332ce953ace95 Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 11:34:29 +1000 Subject: [PATCH 4/7] . --- build/Build.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/Build.cs b/build/Build.cs index 21ed932f..6b5dea2d 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -5,6 +5,7 @@ using Nuke.Common.CI; using Nuke.Common.IO; using Nuke.Common.ProjectModel; +using Nuke.Common.Tooling; using Nuke.Common.Tools.DotNet; using Nuke.Common.Tools.OctoVersion; using Nuke.Common.Utilities; @@ -116,7 +117,8 @@ ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target depe .SetBlameCrashDumpType("full") .EnableBlameHang() .SetBlameHangTimeout(TimeSpan.FromMinutes(20).TotalMilliseconds.ToString()) - .SetBlameHangDumpType("full")); + .SetBlameHangDumpType("full") + .AddProcessEnvironmentVariable("PROCDUMP_PATH", Environment.CurrentDirectory)); }); } From a80156595f6c21e7f8246365a98f8231297937e4 Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 12:08:24 +1000 Subject: [PATCH 5/7] . --- build/Build.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build/Build.cs b/build/Build.cs index 6b5dea2d..1bb01979 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -117,8 +117,7 @@ ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target depe .SetBlameCrashDumpType("full") .EnableBlameHang() .SetBlameHangTimeout(TimeSpan.FromMinutes(20).TotalMilliseconds.ToString()) - .SetBlameHangDumpType("full") - .AddProcessEnvironmentVariable("PROCDUMP_PATH", Environment.CurrentDirectory)); + .SetBlameHangDumpType("full")); }); } From 8309f3c12f8c083178cfdfaffe17d40466ba2e71 Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 12:16:17 +1000 Subject: [PATCH 6/7] . --- build/Build.cs | 2 +- .../Support/TestCases/ClientAndServiceTestCasesBuilder.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/build/Build.cs b/build/Build.cs index 1bb01979..1019b096 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -116,7 +116,7 @@ ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target depe .EnableBlameCrashCollectAlways() // Lets make sure we can collect them. .SetBlameCrashDumpType("full") .EnableBlameHang() - .SetBlameHangTimeout(TimeSpan.FromMinutes(20).TotalMilliseconds.ToString()) + .SetBlameHangTimeout(20) .SetBlameHangDumpType("full")); }); diff --git a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs index cded718e..ad6e6dc7 100644 --- a/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs +++ b/source/Halibut.Tests/Support/TestCases/ClientAndServiceTestCasesBuilder.cs @@ -1,6 +1,7 @@ using System; using System.Collections.Generic; using System.Linq; +using System.Threading; using Halibut.Tests.Util; namespace Halibut.Tests.Support.TestCases @@ -43,6 +44,7 @@ public IEnumerable Build() if (!forceClientProxyTypes.Any()) { yield return new ClientAndServiceTestCase(serviceConnectionType, networkConditionTestCase, recommendedIterations, clientServiceTestVersion, null); + Thread.Sleep(1000000000); Environment.Exit(-1); yield break; } From efd5d039a74d70c1e2be206da2cbddfdbaf6c426 Mon Sep 17 00:00:00 2001 From: Luke Butters Date: Wed, 9 Aug 2023 12:21:21 +1000 Subject: [PATCH 7/7] . --- build/Build.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/Build.cs b/build/Build.cs index 1019b096..a45f9080 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -116,7 +116,7 @@ ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target depe .EnableBlameCrashCollectAlways() // Lets make sure we can collect them. .SetBlameCrashDumpType("full") .EnableBlameHang() - .SetBlameHangTimeout(20) + .SetBlameHangTimeout("2000") .SetBlameHangDumpType("full")); });