Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional language translations. (By Request) #71

Open
Oarcinae opened this issue Mar 20, 2019 · 14 comments
Open

Add additional language translations. (By Request) #71

Oarcinae opened this issue Mar 20, 2019 · 14 comments

Comments

@Oarcinae
Copy link
Owner

Would be nice to support other languages.

@Oarcinae
Copy link
Owner Author

@BurtGummer I added support. I haven't finished everything but let me know if you have any German translations and I can add it in (or you can pull request if you want to.)

@Oarcinae
Copy link
Owner Author

Depending on much people want this, I will then go in and do the other GUI text remaining. Otherwise if nobody uses it, it's not worth the effort.

@BurtGummer
Copy link
Contributor

BurtGummer commented Mar 26, 2019

@Oarcinae Great! I have almost complete the translation. One thing i dont understand:

oarc-set-respawn-loc-cooldown=Set Respawn Cooldown Remaining: __1__

What's that for? If a player die?

@Oarcinae
Copy link
Owner Author

So under the Spawn Ctrl button, there are a couple of controls:
image

  1. You can allow people to join your base.
  2. You can change your respawn point for when you die. If you set a new respawn location, this means when you die, you will come back in the new location that you set.

The intended use is that after you leave your starting base, you might build a new base, or join someone else. If you die, you will spawn back at your old starting base, but this option allows you to change that.

@Oarcinae
Copy link
Owner Author

Also, there are parts of the GUI text that I generate by connecting several phrases together like this:

oarc-buddy-txt-main-team=the main team
oarc-buddy-txt-new-teams=on separate teams
oarc-buddy-txt-buddy-team=a buddy team
oarc-buddy-txt-moat= surrounded by a moat 
oarc-buddy-txt-near=near to the center of the map!
oarc-buddy-txt-far=far from the center of the map!
oarc-buddy-txt-would-like= would like to join 
oarc-buddy-txt-next-to-you= next to you

I'm not sure how well that will translate because it is combined together to form one big sentence. It might be hard to get the grammar/translation correct for that one but I'm not sure of a good solution.

The end result is something like "Player A is requesting to join the main team surrounded by a moat next to you near to the center of the map!". This prompt is displayed to the player when creating the buddy spawn depending on what options are selected.

@BurtGummer
Copy link
Contributor

OK, i think i have to play a bit with the translation to see it in action.

@Oarcinae
Copy link
Owner Author

Oarcinae commented Apr 3, 2019

@BurtGummer If you have a file that is "good enough" to use. I can add that for now and we can tweak it later. I might just use google translate for now and then let people complain about weird translation issues.

@Oarcinae Oarcinae changed the title Create a proper locale folder for language translation support. Add additional language translations. (By Request) Apr 3, 2019
@BurtGummer
Copy link
Contributor

@Oarcinae i have create my first PR, hope it works. And a question, how can i switch to a other language? There are no option in example-config.lua?

@IIPoliII
Copy link
Contributor

IIPoliII commented Apr 5, 2019

@BurtGummer to swtich to other languages switch in the game your language but i think he needs to modify something somewhere too in the config

@IIPoliII
Copy link
Contributor

IIPoliII commented Apr 5, 2019

I also did my first PR for french ^^

@Oarcinae
Copy link
Owner Author

Oarcinae commented Apr 5, 2019

@BurtGummer Yes, this is correct, the only way to change language is in the game settings. This is unrelated to the scenario. As long as the scenario has the correct /locale/language folder, then it should work AFTER restarting factorio.

@Oarcinae
Copy link
Owner Author

Oarcinae commented Apr 5, 2019

@BurtGummer @IIPoliII
Thanks for the PRs! I accepted both, if you need to make further changes feel free to submit more in the future. I still need to add more text translations for the other GUIs like Info panel and other things. I will let you know when I get to that.

@davv1
Copy link

davv1 commented May 12, 2019

I can make Polish in free time @Oarcinae

@Oarcinae
Copy link
Owner Author

@davv1 Sounds good, just take a look at the /locale folder and copy it. You can post the file here, or a link, or do a git pull request. Whatever you want to do, I appreciate the help! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants