Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better exception handling #89

Open
Amertz08 opened this issue Apr 5, 2020 · 0 comments
Open

Better exception handling #89

Amertz08 opened this issue Apr 5, 2020 · 0 comments

Comments

@Amertz08
Copy link
Contributor

Amertz08 commented Apr 5, 2020

There are a few places where we're throwing Exception as well as ValueError. I think for sure with the generic Exception we should be more specific about what is being thrown. If we want to define our own exceptions that would probably be the path. I think this would be much clearer as to what is going on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Amertz08