Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib instead of os #28

Closed
leewujung opened this issue Nov 29, 2021 · 0 comments · Fixed by #115
Closed

Use pathlib instead of os #28

leewujung opened this issue Nov 29, 2021 · 0 comments · Fixed by #115
Assignees
@ctuguinay
Labels
enhancement
Milestone
v0.1.0 (refactor ...

Comments

@leewujung
Copy link
Member

leewujung commented Nov 29, 2021 •
edited
Loading

Some parts of the codebase use pathlib but other parts use os for path handling. Some other parts use pure strings. Let's clean up everything to use pathlib.
@ctuguinay ctuguinay self-assigned this Jun 23, 2023
@ctuguinay ctuguinay moved this to Todo in Echoregions Jun 23, 2023
@ctuguinay ctuguinay removed the status in Echoregions Jun 30, 2023
@ctuguinay ctuguinay moved this to Todo in Echoregions Jul 3, 2023
@ctuguinay ctuguinay moved this from Todo to Review Needed in Echoregions Jul 25, 2023
@ctuguinay ctuguinay linked a pull request Jul 31, 2023 that will close this issue
Improve Testing #115
Merged
@ctuguinay ctuguinay mentioned this issue Jul 31, 2023
Merged
ctuguinay added a commit that referenced this issue Aug 2, 2023
@ctuguinay @pre-commit-ci
Improve Testing (#115)
36d7eaf 
## Improve Testing

This PR closes #58, #107, #85, #112, #113, #99, #53, #28, #120:

- Created and used a new testing suite: New EVL, new EVR, new Zarr file
- New testing suite resolved the warning that arose from #85
- Refactored tests
- Added fixtures
- Added hints
- Added marks
- Added/improved upon numpy docstrings for tests and fixtures
- Added further tests for Lines and Regions2D
- Added functionality and tests for EVR parser to handle missing bbox values and no regions
- Removed the unused convert_points function
- Fixes docstrings that appeared as errors in the readthedocs
- Used Pathlib instead of OS

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Review Needed to Done in Echoregions Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctuguinay ctuguinay

Labels
enhancement
Projects
Echoregions
Status: Done
Milestone
v0.1.0 (refactor echoregions)
Development

Successfully merging a pull request may close this issue.

Improve Testing ctuguinay/echoregions
2 participants
@leewujung @ctuguinay