You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are pieces of the code that does type comparison using type(blah) == mytype. This now seem to fail during pre-commit.ci as seen in PR #119. The better solution when comparing type, use isinstance(blah, mytype).
## Improve Testing
This PR closes#58, #107, #85, #112, #113, #99, #53, #28, #120:
- Created and used a new testing suite: New EVL, new EVR, new Zarr file
- New testing suite resolved the warning that arose from #85
- Refactored tests
- Added fixtures
- Added hints
- Added marks
- Added/improved upon numpy docstrings for tests and fixtures
- Added further tests for Lines and Regions2D
- Added functionality and tests for EVR parser to handle missing bbox values and no regions
- Removed the unused convert_points function
- Fixes docstrings that appeared as errors in the readthedocs
- Used Pathlib instead of OS
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Overview
There are pieces of the code that does type comparison using
type(blah) == mytype
. This now seem to fail during pre-commit.ci as seen in PR #119. The better solution when comparing type, useisinstance(blah, mytype)
.Places with errors
echoregions/echoregions/regions2d/regions2d.py
Lines 413 to 419 in 25a4518
echoregions/echoregions/tests/test_r2d.py
Lines 32 to 37 in 25a4518
The text was updated successfully, but these errors were encountered: