Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In users list, add user "gecos" i.e. full names as well #25

Closed
ericfranz opened this issue Aug 30, 2018 · 4 comments
Closed

In users list, add user "gecos" i.e. full names as well #25

ericfranz opened this issue Aug 30, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@ericfranz
Copy link
Contributor

Instead of having the display value of the select options for users just be the username, it would also be the gecos name i.e. "an0047 - Eric Franz" instead of just "an0047".

Etc.getgrnam('bmishiny').mem.map { |u| { u => Etc.getpwnam(u).gecos } }
=> [{"bmiadmin"=>"BISR Developers"}, {"mrodgers"=>"Morgan Rodgers"},...

Note: it might end up that even this is not enough, and we want something else (like org?). But we can wait on feedback from BISR for that.

@ericfranz ericfranz added the enhancement New feature or request label Aug 30, 2018
@MorganRodgers
Copy link
Contributor

MorganRodgers commented Aug 30, 2018

Is there any guarantee that the GECOS field is only ever going to just be full names? It looks as though it is intended to be a dumping ground of additional information about a user: https://en.wikipedia.org/wiki/Gecos_field

@ericfranz
Copy link
Contributor Author

It has been full name at OSC since I've been here.

@MorganRodgers
Copy link
Contributor

I just spoke with Trey and he described the GECOS field as being the wild west, but felt that it is going to be better come the switch to the OSCUS system. I'll add this as a final feature to the facl_fixes.

@MorganRodgers MorganRodgers mentioned this issue Sep 4, 2018
@MorganRodgers
Copy link
Contributor

Added in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants