Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file alerts need focus #3834

Closed
johrstrom opened this issue Sep 27, 2024 · 0 comments · Fixed by #3939
Closed

file alerts need focus #3834

johrstrom opened this issue Sep 27, 2024 · 0 comments · Fixed by #3939
Assignees
@johrstrom
Labels
bug Existing functionality not working as expected component/file_browser
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

I recently redid the alerting for the files app in #3769, but one thing I missed was when you are scrolled down below this alert and it fires - you actually have no idea that it's on the page until you scroll up. This behavior is likely true for screen readers as well.

So, whenever an alert is fired - it should have the page focus on that element so folks know it's there.
@johrstrom johrstrom added bug Existing functionality not working as expected component/file_browser labels Sep 27, 2024
@johrstrom johrstrom added this to the 4.0 milestone Sep 27, 2024
@johrstrom johrstrom mentioned this issue Nov 6, 2024
Merged
@johrstrom johrstrom self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johrstrom johrstrom

Labels
bug Existing functionality not working as expected component/file_browser
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

scroll when an alert happens OSC/ondemand
1 participant
@johrstrom