Update settings in OOD 3.1.x to allow custom logo control of height and width

[rlara3]

On OOD 3.0, the setting for the size of the home screen logo controlled the height, with the width setting as proportionate:

OOD 3.0
<img src="/public/sos_elsa.png?timestamp=1708715652" alt="logo" class="py-2">

Example:

With OOD 3.1, the width is set at 100, creating issues with the image size. Large and small images are scaled up to the width of the page, creating formatting issues:

OOD 3.1.1
<img src="/public/sos_elsa.png?timestamp=1708717039" alt="logo" class="py-2 w-100">

Example:

The setting is in the file nginx-stage.yml.

[johrstrom]

Hi, thanks for this ticket. This has been patched in the next release, but i'll put this in the 3.1 milestone so that we can pick it up and patch it in some 3.1.x release.

[johrstrom]

As a workaround until it gets released, you can edit this file located /var/www/ood/apps/sys/dashboard/app/helpers/dashboard_helper.rb

ondemand/apps/dashboard/app/helpers/dashboard_helper.rb

Line 16 in b4e6998

image_tag("OpenOnDemand_stack_RGB.svg", alt: "logo", height: "85", class: 'py-2 w-100')

And change this to remove the w-100 class.

- image_tag("OpenOnDemand_stack_RGB.svg", alt: "logo", height: "85", class: 'py-2 w-100') 
+ image_tag("OpenOnDemand_stack_RGB.svg", alt: "logo", height: "85", class: 'py-2') 

[johrstrom]

OK - looks like you need 2 edits in the same function. You can check this backport for the actual diff you need: #3632

[rlara3]

Found the second edit, all is good now. Ruben Lara pace.gatech.edu From: Jeff Ohrstrom ***@***.***> Date: Monday, June 24, 2024 at 1:49 PM To: OSC/ondemand ***@***.***> Cc: Lara, Ruben ***@***.***>, Author ***@***.***> Subject: Re: [OSC/ondemand] Update settings in OOD 3.1.x to allow custom logo control of height and width (Issue #3630) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> OK - looks like you need 2 edits in the same function. You can check this backport for the actual diff you need: #3632<#3632> — Reply to this email directly, view it on GitHub<#3630 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK2USHWOUMK5XPFZDZAIYYDZJBLY7AVCNFSM6AAAAABJ2HNNUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGA4TSOJQHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[johrstrom]

This was fixed in 3.1.7 and will be fixed in future releases too. Thanks for the ticket!