Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for sub apps for menu filtering / filtering (sub) apps per profile #3005

Closed
robinkar opened this issue Sep 4, 2023 · 1 comment · Fixed by #3006
Closed

Metadata for sub apps for menu filtering / filtering (sub) apps per profile #3005

robinkar opened this issue Sep 4, 2023 · 1 comment · Fixed by #3006
Milestone

Comments

@robinkar
Copy link
Contributor

robinkar commented Sep 4, 2023

We are looking into starting to use user profiles with sub apps for profile-specific apps and quick launch apps, although right now it seems like a significant amount of duplication/hardcoding is required to filter out certain (sub) apps in the menus. For example, in the default profile we would most likely have all apps that have no sub apps and all "base" versions of the sub apps available (e.g. ood-jupyter/base), while in the profiles we might have apps like ood-jupyter/pytorch.
We would like to specify just the subcategories/filters without needing to explicitly list every single app we want for each profile.

This seemed like it would have been possible by filtering the apps using metadata, e.g:

# ondemand.d/dashboard.yml
pinned_apps:
  - type: sys
    subcategory: "Servers"
    profile: "ai"
interactive_apps_menu:
  title: "Apps"
  links:
    - group: "Servers"
    - apps:
      - type: sys
        subcategory: "Servers"
        profile: "ai"

Although that works for normal apps, it seems like sub apps don't support metadata as that is defined in manifest.yml only.

Would it be possible to get support for metadata in sub apps, or maybe even better, a list of profiles in the manifest and sub app YML that define the profiles that the app is visible in.
E.g.

# ood-jupyter/local/pytorch.yml
title: "Jupyter: PyTorch"
profiles:
  - ai
# or if only the metadata support is added:
metadata:
  profile: "ai"
@abujeda
Copy link
Contributor

abujeda commented Sep 5, 2023

I think allowing subapps to override metadata is a good idea.

This is a PR to add support for the override: #3006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants