Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate script creation #25

Open
johrstrom opened this issue Sep 16, 2019 · 2 comments
Open

Validate script creation #25

johrstrom opened this issue Sep 16, 2019 · 2 comments

Comments

@johrstrom
Copy link
Contributor

We've noticed this case where

  1. You create a project from a directory that does not exist
    • there's no validation, it lets you do this
  2. You try to create a 'job setting' (script) but you cannot.

You cannot create a new job setting because you cannot choose an appropriate file to render because the project directory was invalid when you created it. The file list is populated by /scenes//[.ma|.mb].

As a user it's not apparent what's gone wrong, because it went wrong on the previous step, not this one.

It's not apparent that you can't create a new job setting (script) because you're project is bad, so let's put a check in place to ensure only valid projects get created. Valid by this standard being that it has 1 or more scene files in it's scene subdirectory.

@johrstrom
Copy link
Contributor Author

I made a couple commits to this so at least when a user does get into this situation they should be aware of it. One bit is it won't submit if the file to render doesn't actually exist.

@johrstrom johrstrom changed the title Validate project creation Validate script creation Jul 26, 2021
@johrstrom
Copy link
Contributor Author

Changing this to validate script creation because we now have test cases for project. This ticket will solely fix creating job settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant