-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2642: LWG 2024/02/28 review #450
Comments
@crtrott Could you please make a PR for the changes that you worked on during yesterday's review? It's OK if it's not done; I just want to make sure it's not lost. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
P2642: LWG 2024/02/28 review
Changes from previous review
LWG is pleased on 2024/02/28. Also pleased with the updated green diff style.
Extra
LEAST-MULTIPLE-AT-LEAST
condition on constructors.Paragraphs 6 and 9 of observers now use preferred if/else/otherwise format.
Resuming
Converting ctor from
layout_stride::mapping
tolayout_right_padded::mapping
.11.1 needs a period; make it a complete sentence. Preconditions generally have implicit and between them, so each can be a complete sentence.
18.1 has a missing closing backtick for
true
. Also, make those Constraints each a stand-alone sentence, just like the preconditions. (Constraints for converting constructor from LayoutLeftPaddedMapping.)20: Capital letter for direct-non-list-initializes.
21: Remove space between
!
and rest of expression.Note after 21: "... affects neither the constraints nor the preconditions."
[mdspan.layout.rightpadded.obs]
Wording for
strides()
could declare the function on one line instead of two.Para 2 Returns: Reformat as one sentence, since it's just two bullets. (Just remove the bullets; leave the current structure.)
(Just for future reference: para 5 is by-construction correct because of the new Mandates and Preconditions.)
Para 9 under
stride
is a bit wacky, but OK to leave alone, since it's consistent with Ranges. (Add an entry to the Editorial Wiki about this.)[mdspan.submdspan.mapping]
(Corresponding to 4.2, there was a bug in the current draft. They actually need to be ordered.)
Add a drafting Note to explain that 4.2 is a drive-by fix, an intentional deviation from the current Draft that LWG reviewed and approved.
layout_right
specialization ofsubmdspan_mapping
, para 1.3, first inner bullet: Add a comma, as withlayout_left
above, to separate out the values.The text was updated successfully, but these errors were encountered: