Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some votes are attributed to the incorrect faction #110

Open
henare opened this issue Nov 23, 2015 · 1 comment
Open

Some votes are attributed to the incorrect faction #110

henare opened this issue Nov 23, 2015 · 1 comment

Comments

@henare
Copy link
Member

henare commented Nov 23, 2015

When fixing #106 we discovered that in the first 3 votes of the parliament, everyone is an independent.

Also, when someone joins the parliament they seem to be listed as independent for their first few votes too. Presumably it's before they've official joined their faction.

We don't support either of these because we need a Member record to associate the vote with. Our upstream Popolo data doesn't have this extra record either (and it doesn't seem practical to do it either - see everypolitician/everypolitician-data#1468 (comment)).

This reminds me of the unresolved upstream issue: openaustralia#4. As this issue also involves changing the underlying mechanisms for how the application and data works, it's highly unlikely we'll fix it as part of this initial project.


So far we know it's affecting:

henare added a commit that referenced this issue Nov 23, 2015
This stops the importer from dying when it encounters the corner case
where we don't have a member record for a person in the right party.
It also means that some votes will be attributed to the incorrect
party, see #110.

Fixes #106
Fixes #107
@henare
Copy link
Member Author

henare commented Nov 23, 2015

Also relevant is that we've now decided we can't support faction changes during a day: #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant