Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BT-106 Procedure Accelerated - translation problems, mandatory rules #1034

Open
tompeeszter opened this issue Oct 4, 2024 · 2 comments
Open
Assignees
Labels
schematrons Related to the Schematron validation (/schematrons SDK folder) translations About labels and translations
Milestone

Comments

@tompeeszter
Copy link

We have noticed the following isse with the field: BT-106-Procedure (name: "Procedure Accelerated").

There are the following rules:

  • BR-BT-00106-0022 (validation-stage-4-16.sch)

    • Schematron rule:
      <assert id="BR-BT-00106-0022" role="ERROR" diagnostics="BT-106-Procedure" test="count(cbc:ProcessReasonCode) &gt; 0 or not(../cbc:ProcedureCode/normalize-space(text()) = ('open','restricted','neg-w-call'))">rule|text|BR-BT-00106-0022</assert>
    • English translation:
      The procedure is accelerated' (BT-106-Procedure) is mandatory in notice type '16 – Contract notice – general directive, standard regime' except when: 'Type of procedure' (BT-105) is 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'
    • Hungarian translation:
      Az eljárás gyorsított' (BT-106-Procedure) kötelező a(z) '16 – Eljárást megindító hirdetmény – általános irányelv, klasszikus ajánlatkérőkre vonatkozó szabályok' hirdetménytípusban, a következő feltétel kivételével:'Az eljárás típusa' (BT-105) 'Nyitott', 'Zárt' vagy 'Eljárást megindító felhívás előzetes közzétételével járó tárgyalásos / tárgyalásos'
    • Problem:
      According to the schematron rule BT-106 is mandatory in notice type '16' when 'Type of procedure' (BT-105) is 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'. Both the english and hungarian translation say the opposite.
  • BR-BT-00106-0053 (validation-stage-4-16.sch)

    • Schematron rule:
      <assert id="BR-BT-00106-0053" role="ERROR" diagnostics="BT-106-Procedure" test="count(cbc:ProcessReasonCode) = 0 or (../cbc:ProcedureCode/normalize-space(text()) = ('open','restricted','neg-w-call'))">rule|text|BR-BT-00106-0053</assert>
    • English translation:
      The procedure is accelerated' (BT-106-Procedure) is not allowed in notice type '16 – Contract notice – general directive, standard regime' when: 'Type of procedure' (BT-105) is 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'
    • Hungarian translation:
      Az eljárás gyorsított' (BT-106-Procedure) nem engedélyezett a '16 – Eljárást megindító hirdetmény – általános irányelv, klasszikus ajánlatkérőkre vonatkozó szabályok' hirdetménytípusban a következő feltételek mellett:'Az eljárás típusa' (BT-105) 'Nyitott', 'Zárt' vagy 'Eljárást megindító felhívás előzetes közzétételével járó tárgyalásos / tárgyalásos'
    • Problem:
      According to the schematron rule BT-106 is forbidden in notice type '16' when 'Type of procedure' (BT-105) is NOT 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'. Both the english and hungarian translation say the opposite.
  • BR-BT-00106-0023 (validation-stage-4-17.sch)

    • Schematron rule:
      <assert id="BR-BT-00106-0023" role="ERROR" diagnostics="BT-106-Procedure" test="count(cbc:ProcessReasonCode) &gt; 0 or not(../cbc:ProcedureCode/normalize-space(text()) = ('open','restricted','neg-w-call','comp-dial','innovation'))">rule|text|BR-BT-00106-0023</assert>
    • English translation:
      The procedure is accelerated' (BT-106-Procedure) is mandatory in notice type '17 – Contract notice – sectoral directive, standard regime' except when: 'Type of procedure' (BT-105) is not 'Open', 'Restricted', 'Negotiated with prior publication of a call for competition / competitive with negotiation', 'Competitive dialogue' or 'Innovation partnership'
    • Hungarian translation:
      Az eljárás gyorsított' (BT-106-Procedure) kötelező a(z) '17 – Eljárást megindító hirdetmény – ágazati irányelv, általános rész' hirdetménytípusban, a következő feltétel kivételével:'Az eljárás típusa' (BT-105) nem 'Nyitott', 'Zárt', 'Eljárást megindító felhívás előzetes közzétételével járó tárgyalásos / tárgyalásos', 'Versenypárbeszéd' vagy 'Innovációs partnerség'
    • Problem:
      According to the schematron rule BT-106 is mandatory in notice type '17' when 'Type of procedure' (BT-105) is 'Open', 'Restricted', 'Negotiated with prior publication of a call for competition / competitive with negotiation', 'Competitive dialogue' or 'Innovation partnership'. Both the english and hungarian translation say the opposite.
  • BR-BT-00106-0036 (validation-stage-4-29.sch)

    • Schematron rule:
      <assert id=""BR-BT-00106-0036"" role=""ERROR"" diagnostics=""BT-106-Procedure"" test=""count(cbc:ProcessReasonCode) = 0 or (../cbc:ProcedureCode/normalize-space(text()) = ('open','restricted','neg-w-call'))"">rule|text|BR-BT-00106-0036</assert>
    • English translation:
      The procedure is accelerated' (BT-106-Procedure) is not allowed in notice type '29 – Contract award notice – general directive, standard regime' when: 'Type of procedure' (BT-105) is 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'
    • Hungarian translation:
      Az eljárás gyorsított' (BT-106-Procedure) nem engedélyezett a '29 – Tájékoztató az eljárás eredményéről – általános irányelv, klasszikus ajánlatkérőkre vonatkozó szabályok' hirdetménytípusban a következő feltételek mellett:'Az eljárás típusa' (BT-105) 'Nyitott', 'Zárt' vagy 'Eljárást megindító felhívás előzetes közzétételével járó tárgyalásos / tárgyalásos'
    • Problem:
      According to the schematron rule BT-106 is forbidden in notice type '29' when 'Type of procedure' (BT-105) is NOT 'Open', 'Restricted' or 'Negotiated with prior publication of a call for competition / competitive with negotiation'. Both the english and hungarian translation say the opposite.

The second part of the issue is that the mandatory rules aren't invited during schematron validation.
For example according to the rule BR-BT-00106-0022 (validation-stage-4-16.sch) we should send BT-106 (in case of BT-105='Open'), but we don't recive any ERROR during the validation. I send you an xml example.
BT_106.txt

We use SDK 1.11.1.

Could you please investigate this issue?
Thanks in advance!

@YvesJo YvesJo self-assigned this Oct 7, 2024
@YvesJo YvesJo added schematrons Related to the Schematron validation (/schematrons SDK folder) translations About labels and translations labels Oct 7, 2024
@YvesJo YvesJo added this to the SDK 1.13.0 milestone Oct 7, 2024
@YvesJo
Copy link
Contributor

YvesJo commented Oct 7, 2024

Hi,
Thanks for reporting your concerns.
There are 2 issues involved.
The first one is a wrong label for a condition that applies to rules BR-BT-00106-0022, BR-BT-00106-0036 and BR-BT-00106-0053. this will get fixed with SDK 1.13 and backported down to SDK 1.11.
The second one is relative to the rule context which has been updated with SDK 1.12 (and can't however get backported as this would make the SDK 1.11 rules stricter) and had to be changed from the parent node to another ancestor for the mandatory rules to be effective
KR.

@tompeeszter
Copy link
Author

Thanks for the rapid answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schematrons Related to the Schematron validation (/schematrons SDK folder) translations About labels and translations
Projects
None yet
Development

No branches or pull requests

2 participants