Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "RAS-1305 Introduce non root application user" #997

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Revert "RAS-1305 Introduce non root application user" #997

merged 1 commit into from
Oct 14, 2024

Conversation

arroyoAle
Copy link
Contributor

@arroyoAle arroyoAle commented Oct 14, 2024 •
edited
Loading

Reverts #996 because of an issue with gnupg causing errors when trying to upload a seft

To test

  • deploy to your env
  • make sure frontstage still works
  • ensure you can still upload a seft to frontstage

JIRA

RAS-1322

@arroyoAle arroyoAle marked this pull request as ready for review October 14, 2024 12:11
pricem14pc
pricem14pc approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed the revert of the appuser.

@anwilkie
Copy link
Contributor

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-997

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-997

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

anwilkie
anwilkie approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@anwilkie anwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run tests and confirmed SEFT upload works.

SteveScorfield
SteveScorfield approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests and tested a SEFT. All is fine. Code looks fine. Approved.

@arroyoAle arroyoAle merged commit 2708765 into main Oct 14, 2024
3 checks passed
@arroyoAle arroyoAle deleted the revert-996-image-vulnerabilites branch October 14, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveScorfield SteveScorfield SteveScorfield approved these changes

@anwilkie anwilkie anwilkie approved these changes

@pricem14pc pricem14pc pricem14pc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arroyoAle @anwilkie @ras-rm-pr-bot @SteveScorfield @pricem14pc