RAS-1298: Add a new survey page #1003
Conversation
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
|
|
||
| {% set page_title = "Add a survey" %} | ||
| {% block breadcrumbs %} |
There was a problem hiding this comment.
The style inherited from the design system for the breadcrumbs that there is padding of 8px around the link text. Karen is happy for this to replace the "ons-u-mb-s" (18px) margin.
| }) | ||
| %} | ||
| <p>If your enrolment code has been lost, does not work or you did not receive one, request a new code.</p> | ||
| <p>To do this, call +44 300 1234 931 or <a href='/surveys/help/something-else'>send a message</a></p> |
There was a problem hiding this comment.
I have spoken to Karen about where specifically this "send a message" link needs to point to. It will eventually point to the link created as part of the "Send message" journey. I have made a note in both cards and links so that this link is updated once the work has been completed.
There was a problem hiding this comment.
If you go down this route currently it leads to 500 errors but as the journey is updated in a separate card no issues. Just calling it out for the following card associated with adding a survey.
|
|
||
| {% set breadcrumbsData = [ | ||
| { | ||
| "text": "Surveys", |
There was a problem hiding this comment.
Breadcrumbs should display "back" not "surveys"
There was a problem hiding this comment.
Good spot. Not sure how I missed this! I've updated it now.
There was a problem hiding this comment.
I think we need to take another look at this and refactor /add-survey, it is a bit of mess and this just builds on that. There is all sorts of code and logging duplication, exceptions that can't happen and very odd use of form data which is purely a error dict {"error": {"type": "failed"}} or {"error": {}}. This then makes this bit really odd {% set errorType = data['error']['type'] %} and then the logic % if errorType == "failed" %}.
The defining of vars to use once i.e {% set errorMsg = 'Enter a valid enrolment code' %} is also not something I would expect and should be fed by the validation step in the backend. There is also some mixing of speech marks which I am unsure why we are doing.
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
What and why?
As part of the user journey improvement work, there is a requirement to update and improve the add survey section. This PR achieves this.
How to test?
Jira
https://jira.ons.gov.uk/browse/RAS-1298