adding ignore #340
Merged
adding ignore #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy wilkia |
|
Deploying to dev cluster with following parameters:
|
arroyoAle
requested changes
Oct 21, 2024
There was a problem hiding this comment.
While they look fine we shouldn't just update all the dependencies like this, we don't really know whats coming through so if anything breaks it'll be lost - I think the card was more looking at progressing any security dependencies rather than a general update
matthew-robinson-ons
approved these changes
Oct 23, 2024
arroyoAle
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR adds an ignore to the makefile.
How to test?
Deploy and run tests.
Do pipenv install, pipenv graph, and check following dependencies:
flask-cors = “>=4.0.2”
requests = “>=2.32.0”
Jira
Card