Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recreate dockerfile branch with signed commits #335

Merged
merged 7 commits into from
Aug 12, 2024
Merged

recreate dockerfile branch with signed commits #335

merged 7 commits into from
Aug 12, 2024

Conversation

anwilkie
Copy link
Contributor

@anwilkie anwilkie commented Aug 1, 2024 •
edited
Loading

What and why?

This PR moves the dockerfile to the _infra/docker directory and adds signed commits.

In addition, the certifi dependency has been updated.

How to test?

Check GA build.

Jira

Card

arroyoAle
arroyoAle approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@arroyoAle arroyoAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, build works, and docker compose works as expected

@anwilkie anwilkie mentioned this pull request Aug 2, 2024
Closed
matthew-robinson-ons
matthew-robinson-ons requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes in the pipfile.lock which i can't see documented. Will be hard to work out what has gone wrong if something breaks.

@anwilkie
Copy link
Contributor Author

anwilkie commented Aug 8, 2024

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-335

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

matthew-robinson-ons
matthew-robinson-ons approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and dependencies/vulnerabilites updated

@anwilkie anwilkie merged commit 1f1c796 into main Aug 12, 2024
1 check passed
@anwilkie anwilkie deleted the ras-313-dockerfile-consistency-with-signed-commits branch August 12, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-robinson-ons matthew-robinson-ons matthew-robinson-ons approved these changes

@arroyoAle arroyoAle arroyoAle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anwilkie @ras-rm-pr-bot @arroyoAle @matthew-robinson-ons