Field

[bameyrick]

Use this place to discuss the field component in the ONS Design System

[dudelmeister]

For some reason fields with a prefix or suffix are showing a height of 41px, single line input fields should have a consistent height of 40px (isn't this normally inherited?)

[bameyrick]

The legend field should accept HTML for when the legend is also the <h1> of the page.

Resolved in #159

[bameyrick]

When a field is called by another component (e.g. onsInput, onsSelect, onsCheckboxes, onsRadios, onsDateInput, onsPassword, onsTextarea, onsUpload) it should be possible to set field classes, field ids, field attributes, and legend classes from the calling component.

Resolved in #161

[bameyrick]

The last field__item or the last nested field shouldn't have a margin-bottom if it is not wrapped in field__group.

Also, field__group should have a margin-bottom of -1 * the margin-bottom of the inner field__items.

[bameyrick]

Having looked at the layout of a question form, and following discussions with @will-madebymoon and @jrbarnes9, we should probably move the styling for spacing between fields to the fields themselves rather than from _question.scss.

[bameyrick]

We should probably to update the field to component to use <p> tags (when not rendering as a <fieldset>) as recommended by WHATWG: https://html.spec.whatwg.org/multipage/forms.html#writing-a-form's-user-interface

[bameyrick]

The noField parameter is not documented on any inputs that utilise the field component. We should document this on all inputs.

[bameyrick]

When a field has a mutually exclusive option the labels are not rendering.

[bameyrick]

The legend has display: table set by default, which may prevent screen readers from reading it when they're not visually hidden.

[bameyrick]

Using to automatically switch between fieldsets, and p tags based on whether they are calling input has mutuallyExclusive(#29) config specified is too complex and causes issues when in use in projects like runner. We should separate all the logic held in the field component into separate mutually exclusive, field, and fieldset macros that are simpler to use.

[bameyrick]

Field groups don't space themselves out correctly:

[bameyrick]

Input does not render in eq-survey runner with mutually exclusive set as the wrapping onsField element has no params object set.

[jrbarnes9]

Incorrect description of field parameter 'inline'.

It adds a class ons-field--inline to the field div, which displays the label inline with the input. It doesn't allow users to place multipe fields side-by-side.

[jrbarnes9]

Raised #2568