Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nStore - B2C Exports - compliance check #1598

Open
abhinavv245 opened this issue Jul 19, 2024 · 2 comments
Open

nStore - B2C Exports - compliance check #1598

abhinavv245 opened this issue Jul 19, 2024 · 2 comments

Comments

@abhinavv245
Copy link
Collaborator

/on_search

  • context must have required property 'version', 'ttl"
  • Message ID for on_action API should be same as action API: "b00cd212-9398-4039-98db-5331db22154e"
  • items/category_ids cannot be null
  • either amount or percentage should be provided in cancellation_terms/cancellation_fee
  • items/time/label - enable is not a valid attribute(range is missing in time, timestamp is invalid)
  • in provider/tags for serviceability, category/value is missing
  • catalog/descriptor/images/0 must be object
  • providers/0/descriptor must have required property 'code'
  • providers/0/tags/0 must have required property 'descriptor' (Serviceability)",
  • providers/0/tags/0/list/1 must have required property 'value' (Category)"
  • providers/0/items/0 must have required property 'replacement_terms'",
  • providers/0/items/0 must have required property 'matched'",
  • providers/0/items/0 must have required property 'recommended'",
  • items/0/quantity/available/count must be integer
  • providers/0/items/tags must have required property 'descriptor'
  • providers/0/items/tags/list must have required property 'descriptor'

/on_select

  • quote should be in 'USD' as provided in 'on_search'
  • context must have required property 'ttl'

/init

  • billing/tax_id should be valid

/on_init

  • context must have required property 'ttl'
  • order must have required property 'cancellation_terms'",
  • order must have required property 'payments'",
  • fulfillments/0/@ondc1org1provider_name must be equal to constant (nStore - Fashion)
  • order/tags/ must have required property 'descriptor'",
  • order/tags/list/ must have required property 'value'

/confirm

  • order must have required property 'cancellation_terms'",
  • provider/locations/0 cannot be null",
  • payments/0/type must be equal to constant (PRE-FULFILLMENT)
  • payments/collected_by should be 'SOR'

/on_confirm

  • context must have required property 'ttl'
  • order must have required property 'cancellation_terms'
  • invalid fulfillments object (refer to the developer guide)

/on_status

  • similar issues as above
  • Delivery time range (fulfillments/end/time/range) is required for fulfillment state - Order-picked-up, Out-for-delivery, Order-delivered
  • Delivery timestamp (fulfillments/end/time/timestamp) is required for fulfillment state - Order-delivered",
  • Delivery proof (fulfillments/stops(start)/instructions/images) is required once the order is picked"
  • Delivery proof (fulfillments/stops(end)/instructions/images) is required once the order is delivered"
  • fulfillments/tags (routing) is not part of 2.0 specs

Note: Kindly use the log verification tool to self rectify the errors as per API specifications.

@nstoretech

@abhinavv245
Copy link
Collaborator Author

All Flows

/search

  • city code should be std:999 and country code IND for now

/on_search

  • search and onsearch context timestamps cannot be same
  • category codes to be used in category_ids array in items, and category value in serviceability (in case serviceable for all categories use 'RET12-*')

/select

  • country code 'IND' not valid for address of USA in /fulfillments
  • stops/gps is changed from /search

/on_select

  • In select, buyer selects the 'Delivery' Fulfillment, why in on_select multiple fulfillment options provided (Delivery and Self Pickup) (implemented as per 1.2)
  • quote should be in USD

/init

  • end location should not be changed in fulfillments/stops

/on_init

  • payments/uri is missing
  • how is the payment status 'PAID'

/confirm

  • quote is in INR, payments amount is in USD?

Flow 4 and 5

/on_cancel

  • Refund line items needs to be included in the quote breakup to reimburse certain charges from the quote.
  • Another payment object will be added for refund (refer to specs)
  • payments/id is missing

@nstoretech

@abhinavv245
Copy link
Collaborator Author

All Flows

/search

  • city code should be std:999 for now (instead of 'std:*')

/on_select

  • quote should be in USD

/init

  • end details should not be changed in fulfillments/stops

/on_init

  • payments/uri is missing
  • how is the payment status 'PAID'

/confirm

  • order/payments/0/status must be equal to one of the allowed values (PAID,NOT-PAID)
  • quote is in INR, payments amount is in USD? (should be in USD)

/on_confirm

  • what is fulfillments/time/range provided for? (range is provided inside stops)

/on_status

  • pickup timestamp (fulfillments/stops(start)/time/timestamp) should not be removed once recorded after order picked up (At Destination hub, Domestic custom cleared, etc)
  • Pickup proof (fulfillments/stops/start/instructions/images) is required once the order is picked-up"
  • Delivery proof (fulfillments/stops/end/instructions/images) is required once the order is delivered

Cancellation Flows

/on_cancel

  • invalid payload (should be as per 2.0.2)

Note: Many repeated issues identified, kindly fix all the previous issues before resubmission.Let us know if you any concerns.

@nstoretech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant