Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to all functions #14

Open
kzollove opened this issue Sep 9, 2022 · 3 comments
Open

Add unit tests to all functions #14

kzollove opened this issue Sep 9, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kzollove
Copy link
Collaborator

kzollove commented Sep 9, 2022

See HADES developer guidelines for unit tests
@kzollove kzollove added the enhancement New feature or request label Sep 9, 2022
@kzollove
Copy link
Collaborator Author

Look into R package dittodb for testing functions that require database connection. Will probably require waiting for OHDSI/GIS#83 to be resolved

@kzollove kzollove mentioned this issue Sep 25, 2022
Merged
@kzollove
Copy link
Collaborator Author

kzollove commented Sep 8, 2023

After chatting with Jared, it seems it may be best to

  1. set up a testing database that contains input and output test files. This could be wrapped in a container so developers can easily stand it up
  2. build tests against this database outside of R's testthat framework (this also serves to keep them language independent)

@kzollove
Copy link
Collaborator Author

This has been started with 459bee6

@kzollove kzollove added the good first issue Good for newcomers label Dec 8, 2023
@kzollove kzollove transferred this issue from OHDSI/GIS Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
GIS Project Management
Status: 🏷TODO
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzollove