Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bug in predictCyclopsType #507

Closed
jreps opened this issue Dec 3, 2024 · 2 comments
Closed

small bug in predictCyclopsType #507

jreps opened this issue Dec 3, 2024 · 2 comments

Comments

@jreps
Copy link
Collaborator

jreps commented Dec 3, 2024

in predictCyclopsType() there is the line:

intercept <- coefficients$betas[coefficients$covariateId%in%'(Intercept)']

I believe there is a missing 's' and this should be

intercept <- coefficients$betas[coefficients$covariateIds%in%'(Intercept)']

I think this will not cause issues because R lets you be lazy with the names but we should fix this anyway in case things change.

@egillax egillax self-assigned this Dec 4, 2024
@egillax egillax added the bug label Dec 4, 2024
@egillax
Copy link
Collaborator

egillax commented Dec 4, 2024

Thanks! This stuff worried me when I saw your issue. But as you say R does some magic and still gets the intercept. I've made a PR to fix this and will merge once green.

@egillax
Copy link
Collaborator

egillax commented Dec 9, 2024

Fixed with #508

@egillax egillax closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants