Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky stratifiedImputation test #500

Closed
egillax opened this issue Nov 1, 2024 · 2 comments
Closed

Fix flaky stratifiedImputation test #500

egillax opened this issue Nov 1, 2024 · 2 comments
Labels
bug ci continous integration
Milestone

Comments

@egillax
Copy link
Collaborator

egillax commented Nov 1, 2024

This test fails occasionally:

── Failure ('test-featureEngineering.R:279:3'): createStratifiedImputationSettings correct class ──
nrow(stratifiedMeans) == 8 is not TRUE

`actual`:   FALSE
`expected`: TRUE 
@egillax egillax added bug ci continous integration labels Nov 1, 2024
@egillax egillax added this to the version 6.4 milestone Dec 9, 2024
@egillax
Copy link
Collaborator Author

egillax commented Dec 9, 2024

This one is bad as well:

── Error ('test-demographicSummary.R:63:3'): getDemographicSummary ─────────────
Error in ``$<-.data.frame(tmp`, "PersonCountWithOutcome", value = numeric(0))`: replacement has 0 rows, data has 22
Backtrace:

  1. └─PatientLevelPrediction:::getDemographicSummary_survival(...) at test-demographicSummary.R:63:3
  2. ├─base::$<-(*tmp*, "PersonCountWithOutcome", value = <dbl>)
  3. └─base::$<-.data.frame(*tmp*, "PersonCountWithOutcome", value = <dbl>)

egillax added a commit that referenced this issue Dec 9, 2024
@egillax
Copy link
Collaborator Author

egillax commented Dec 9, 2024

Fixed in #510

@egillax egillax closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci continous integration
Projects
None yet
Development

No branches or pull requests

1 participant