Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadGeometry fails to transform geom_local_value when source is character #195

Closed
kzollove opened this issue Jun 10, 2023 · 4 comments
Closed
Labels
R Package Pertinent to the R Package 🕷️ bug Erroneous behavior that needs to be fixed.

Comments

@kzollove
Copy link
Collaborator

image

This issue manifests as unable to transform source to wgs84, but after a little digging, it forces another issue: how to handle source data that contains multiple CRS.

Solution for multiple CRS: break into distinct DFs by CRS, transform to wgs84, then recombine.

When should this CRS step occur? Probably before the main error in this issue is ever encountered... A bit of a chicken or egg situation.

@kzollove kzollove added 🕷️ bug Erroneous behavior that needs to be fixed. R Package Pertinent to the R Package labels Jun 10, 2023
@tibbben
Copy link
Collaborator

tibbben commented Sep 19, 2023

Just need to force geom type on column, sometimes the geom column comes in as archer (not geom) during ETL.

@kzollove
Copy link
Collaborator Author

This was related to a data_source that isn't in the main catalog, but should be.

Once OHDSI/gaiaDB#24 and OHDSI/gaiaDB#9 are closed, try this again (101 in the example picture refers to aqs_sites from OHDSI/gaiaDB#24)

@kzollove
Copy link
Collaborator Author

Not sure if this is the exact same bug, but this can seemingly be reproduced with:

image

@kzollove kzollove moved this to 💡 Idea in GIS Project Management Dec 8, 2023
@kzollove kzollove moved this from 💡 Idea to 🏷TODO in GIS Project Management Dec 8, 2023
@kzollove
Copy link
Collaborator Author

kzollove commented Dec 8, 2023

Not sure if this is still a thing, would like to see if it can be reproduced.

If so address immediately.

@github-project-automation github-project-automation bot moved this from 🏷TODO to ✔Done in GIS Project Management Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R Package Pertinent to the R Package 🕷️ bug Erroneous behavior that needs to be fixed.
Projects
Status: ✔Done
Development

No branches or pull requests

2 participants