Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poincare: Add generic getFeatureInfo method to dataset class #127

Open
egillax opened this issue Aug 22, 2024 · 0 comments
Open

Poincare: Add generic getFeatureInfo method to dataset class #127

egillax opened this issue Aug 22, 2024 · 0 comments

Comments

@egillax
Copy link
Collaborator

egillax commented Aug 22, 2024

The initial layers in the models need some info about the data to be initialized with the correct tensor sizes.

Currently this is handled by two methods here get_cat_features and get_num_features. Methods defined here

Now when we are adding a new type of features, embeddings that have already been generated, we should rethink this approach.

I think we should add a new method to the dataset class, something like get_feature_info to replace the other two. The output of that would be stored in the modelParameters$featureInfo. This way the dataset can provide all the info needed and the model needs to deal with extracting the correct bits to initalize it's layers correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant