Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightweight shiny app #6

Open
anthonysena opened this issue Jan 18, 2022 · 4 comments
Open

Add lightweight shiny app #6

anthonysena opened this issue Jan 18, 2022 · 4 comments

Comments

@anthonysena
Copy link
Collaborator

It would be useful to have a small shiny app for reviewing the cohort generation results

@schuemie
Copy link
Member

As I'll discuss during a HADES meeting (hopefully the next one), I'd like all HADES packages to follow the same pattern:

  1. Export results as CSV files (for CohortGenerator this might be information on the cohort definitions, and counts of cohorts in the data).
  2. View results in the CSV files using a Shiny app.

The data model of the CSV files should be documented like this. Ideally, all Shiny apps should be able to work both with CSV files (possibly pre-processed for efficiency), as well as a (Postgres) database backend for when data get big. Also, and I'm not yet sure how to do this, but the Shiny app would really be a module, meaning it could be integrated into a bigger Shiny app, for example a study that uses the CohortGenerator package, but also has other results to show.

@anthonysena
Copy link
Collaborator Author

Also, and I'm not yet sure how to do this, but the Shiny app would really be a module, meaning it could be integrated into a bigger Shiny app, for example a study that uses the CohortGenerator package, but also has other results to show.

Perhaps adding the module(s) required for displaying cohort stats should live in: https://github.com/OHDSI/OhdsiShinyModules and then the CohortGenerator package would list this in the Suggests section of the DESCRIPTION file?

@schuemie
Copy link
Member

I was thinking the analytic code, data model for the analytics results, and Shiny module for displaying those results would all live in the same package. But I can see why having the different modules in the same package can help improve integration of the modules. I'm honestly not sure what the right approach would be.

@gowthamrao
Copy link
Member

Why not use the module version of cohort page in cohort diagnostics diagnostic explorer?

It gives everything we need, including human readable text and counts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants