Cannot make cohort definition with concept set having concepts which are not in the vocabulary with highest priority

[marek05]

Atlas version: 2.14.0
WebAPI version: 2.14.0

Related issue: #2764

Expected behavior

• We add new CDM with a new vocabulary to Atlas and leaving old CDM-s also in Atlas.

• We do not set the new CDM and vocabulary to the highest priority in table source_daimon in webapi schema.

• We select under configuration the newest version of vocabulary manually.

• Then we build a concept set with concepts not in the old vocabulary but is in the new one. The concept set in correctly created.

• Then when we want to build the cohort definition then adding the concept set to the inclusion criteria works correctly.

Actual behavior

• Everything works as expected until cohort definition.

• When I make a new cohort definition and try to select the concept from the library then it keeps just loading and does not add it.

• From javascript console I can see the following error: Current data source does not contain required concepts (36853018) and I cannot add the concept set.

• When we set the priority value for the newest CDM and vocabulary to the highest value then everything works as expected.

Steps to reproduce behavior

• Have two CDM-s with different versions of vocabulary.

• In our case we had vocabulary from 2022 (v5.0 02-JUN-22) and 2024 (v5.0 30-AUG-24).

• The priority of the new vocabulary has to be lower than for the older one.

• Select under Configuration the newest vocabulary manually.

• Find a concept that is not in old vocabulary but is in new one (e.g. 36853018 in our case).

• Build a concept set using it. This works correctly.

• When building a cohort definition then adding the concept set does not work and gives the error Current data source does not contain required concepts (36853018).

It seems that when building a cohort definition it is not taken account which vocabulary is selected under Configuration and the one with highest priority is used. The concept set is checked against the highest priority one.

Possibly solutions:

1. Don't check concepts when adding the concept sets. Under concept set mark that these are not in the vocabulary (similar to proposed solution in issue Concept Set JSON with CONCEPT_ID Not in Your Vocab #2764 )
2. Use the vocabulary selected under Configuration to check the concepts.
   Maybe there are some better ideas for this.