remove old unused files and msvc references <version 1800 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to test this by hand. Some of the warnings disables you're removing were introduced in a particular MSVC version but that doesn't mean they can be re-enabled. Particularly I'm almost certain the CRT warning disables are still needed |
revert removed pragma
revert removed #pragma
|
@darksylinc I re-entered the #pragma code |
darksylinc
force-pushed
the
master
branch
4 times, most recently
from
76d820e to
03fbfb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Other" folder contains unreferenced old software.
remove msvc references < v1800