[18.0][MIG] product_multi_company: Migration to 18.0 #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
========================================== Product permissions for discrete companies ========================================== This modules allows to select in which of the companies you want to use each of the products. Installation ============ This module uses the post and uninstall hooks for updating default product template security rule. This only means that updating the module will not restore the security rule this module changes. Only a complete removal and reinstallation will serve. Usage ===== On the product form view, go to the "Information" tab, and put the companies in which you want to use that product. If none is selected, the product will be visible in all of them. The default value is the current one.
* Rename manifest * Change openerp references to odoo * Bump version * Add pragma no cover * Edit security of product employee to allow writes (in tests) * Fix permissions in tests * Fix domain & add test * Implement base_multi_company on product_multi_company * Add related cols for product variant
…figurator When this module is integrated with `product_variant_configurator`, tests fail because the latter makes some black magic on the `name` field. I switch the tests to rely on the `description_sale` field instead, which isn't touched by that module, and is also a field delegated from the related `product.template`. BTW it doesn't make sense to modify provided permissions on a test that checks access errors, so instead I switched them to use users in a group that should have access in production. @Tecnativa TT27288
Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-13.0/multi-company-13.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-13-0/multi-company-13-0-product_multi_company/es/
In order to extend testing, a common class is necessary to avoid code duplication.
…ect context As some default values can come from current company (e.g.: main one), change context when creating.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-15.0/multi-company-15.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-product_multi_company/
Currently translated at 100.0% (7 of 7 strings) Translation: multi-company-15.0/multi-company-15.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-product_multi_company/es/
Remove dependency to stock and its overwritten fields, this logic should go if ever done in a separate module named: product_multi_company_stock TT48972
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-16.0/multi-company-16.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-product_multi_company/
The description shouldn't be overriden in any child module, as it's a traversal data that then changes all the translations.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-16.0/multi-company-16.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-product_multi_company/
Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-16.0/multi-company-16.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-product_multi_company/it/
product.product has a delageted inheritance from product.template so we
are getting the fields logic but not the ORM logic. We need some of that
logic in the search method to be able to get the right results with
domains like [("company_id", "in", [1, False]) to include records which
are shared between companies.
TT51779
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-17.0/multi-company-17.0-product_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-17-0/multi-company-17-0-product_multi_company/
4 tasks
chienandalu
reviewed
Nov 26, 2024
Comment on lines
127
to
130
| ("company_id", "in", [self.company_1.id, False]), | ||
| ("id", "in", expected_products.product_tmpl_id.ids), | ||
| "|", | ||
| ("company_id", "=", self.company_1.id), | ||
| ("company_id", "=", False), |
There was a problem hiding this comment.
You can't change the test condition to fit your needs. Take a look on why this domain shape needs to be tested: b240644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.