Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiss QR Bill/Invoice 30th June 2020 http://qr-bill.ch #416

Closed
giordano-ch opened this issue Apr 19, 2018 · 70 comments
Closed

Swiss QR Bill/Invoice 30th June 2020 http://qr-bill.ch #416

giordano-ch opened this issue Apr 19, 2018 · 70 comments
Labels
odoo_core_related stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@giordano-ch
Copy link

giordano-ch commented Apr 19, 2018

The Swiss QR Bill will replace the payment slip.

You'll find more information under: https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf

is there already something planned? Will the QR-Invoice be a part of l10n_ch standard?

Thanks for any information.


UPDATE

Availability of QR-bill generation per Odoo version

Odoo v10 ✔️

An OCA module is available at

https://github.com/OCA/l10n-switzerland/tree/10.0/l10n_ch_qr_bill

A second module to ease reconciliation process will be available soon #556

Odoo v11

Currently no module is available on OCA. A forward port of Odoo v10 can be done.

Odoo v12 ✔️

Available in official l10n_ch module since 2020-07-16.

Odoo v13 ✔️

Available in official l10n_ch module since 2020-06-26.

@yvaucher
Copy link
Member

The QR code code should normally go in odoo core as the BVR it now maintained there.

The good place to report this can be here:

odoo/odoo#20416

@Guisolan
Copy link

Hello,
we (Prisme) have develop QR Bill for ODOO10
Best regards

@yvaucher
Copy link
Member

@Guisolan welcome on Github and on the OCA.

That's great news, thanks for informing us.

Currently, Odoo Swiss users that cannot afford to migrate to Odoo 11.0 will surely need a module in former versions of Odoo. We will then probably need a version in 10.0 but also in 9.0 for former Odoo versions.

Is your module available anywhere? Github or app.odoo.com? I could find it anywhere.
Is @Prisme-Solutions-Informatique-SA willing to contribute to the Switzerland localization?

@clxadmin
Copy link

Hello,
I'm also interested to this module . @Guisolan, can you tell us more about your module? Is it available somewhere? How can we participate?

@Guisolan
Copy link

Guisolan commented May 29, 2018 via email

@clxadmin
Copy link

Hello Guisolan,

I thank you for your feedback :-)

We have develop the QR code module for Switzerland for Odoo10.

great. Is it somewhere available?

Do you need more ?

I also would like to run it on Odoo 11. Is this also available?

Please let me know what are the posibilities to get this module. As I wrote before I also would like to participate if there is a hand needed

Best regards

@Guisolan
Copy link

Guisolan commented Jun 1, 2018 via email

@clxadmin
Copy link

clxadmin commented Jun 1, 2018

hello,

thats very kind of you. I will watch your repo https://github.com/Prisme-Solutions-Informatique-SA/PRISME-ODOO

We try to upgrade code for the V10 to V11 and publish it to the community if this is ok for you

@Guisolan
Copy link

Guisolan commented Jun 1, 2018 via email

@clxadmin
Copy link

clxadmin commented Jun 4, 2018

Hello,

I'll test the modules with https://qr-validation.iso-payments.ch :-)

Still have no module V10 for download. Is it possible you place it to your prism repo https://github.com/Prisme-Solutions-Informatique-SA/PRISME-ODOO ?

that would be very nice and I thank you

@giordano-ch
Copy link
Author

@clxadmin I think you have to change the branch to 10.0 then you'll find it (prisme_invoice_iban_qrcode)

@Guisolan
Copy link

Guisolan commented Jun 4, 2018 via email

@clxadmin
Copy link

clxadmin commented Jun 5, 2018

I finally found the module -- I thank you

@yvaucher
Copy link
Member

yvaucher commented Jul 4, 2018

@Guisolan Thank you for the link!

You might want to specify the licence in the module __manifest__.py file. Which should be AGPL as the modules depends on l10n_ch_payment_slip.

Talking about l10n_ch_payment_slip
For v11, I must state that I first thought the official ISR report in Odoo core would be enough, but it doesn't cover all needs.

Thus, at first we abandoned the idea of porting l10n_ch_payment_slip to v 11.
However, lastly we reopened #373 to complete it.

And as PRISM module depends on it, I'm glad we did, this should ease the port of PRISME modue from v10 to v11.

However, it seems that the PRISME module for QR code doesn't need all features of l10n_ch_payment_slip. It could be a better approach to extract the current reportlab ISR report into a second module.

In the long term, QR code printout should be included in Odoo core. But, it usually takes time for Odoo to include such features. And users will need it in previous versions too only few will start right away on v 12. Thus, if there is any PR for v11 to include it in this repository just ping me and I'll review it. Even a backport to v9 could be possible.

@robertrottermann
Copy link

We are in the process to create a report for the iso20022 qrcode invoice. It will be for V9.
What we did so far is based on the v9 Paymentslip module
Tomorrow I will discuss with my team how to proceed.

@robertrottermann
Copy link

robertrottermann commented Jul 5, 2018

According to SIX the QR code will only be mandatory June 30th 2020
So there is no immediate hurry to provide it.
This Info I just got by a customer that is very close to SIX.

@pegonzalezs
Copy link

Dear @robertrottermann @yvaucher
my company needs this functionality for v9, so I would like to contribute on this backport. So, we keep us posted about it.
Thank you

@Guisolan
Copy link

Guisolan commented Jul 24, 2018 via email

@didierdonze
Copy link

Hello,
Any updates in this thread? Did someone open a PR to migrate the Prisme module to V11?

@Guisolan
Copy link

Guisolan commented Jan 29, 2019 via email

@didierdonze
Copy link

Hi,
Some news on the subject. Odoo did developp the feature in V12:
odoo/odoo@68dafa0
It's hidden for the moment, but can be teste
image
d.

The slip is missing for the moment. I guess no need to develop a community module in V12, for the moment at least, we might need to backport to V10/11 for our customers.

@Guisolan
Copy link

Guisolan commented Jan 31, 2019 via email

@clxadmin
Copy link

Hello,

Yes, looks like its only available for 12 Enterprise
Screenshot - 2019-03-14T143134 986

@yvaucher
Copy link
Member

yvaucher commented Apr 17, 2019

@clxadmin the option in enterprise is not the Swiss QR Code

SEPA QR Code != Swiss QR code invoice

Currently the report is in Odoo Community core

You can see the xml file that defines the addition to the invoice report here:
https://github.com/odoo/odoo/blob/12.0/addons/l10n_ch/report/swissqr_report.xml

You can activate it by adding an ir.config_parameter named : l10n_ch.print_qrcode

@yvaucher
Copy link
Member

Some news about QR-Invoice here is a PR on master which should improve it's launching on 20th of June 2020.

odoo/odoo#35931

@yvaucher yvaucher changed the title Swiss QR Bill/Invoice 2019 Swiss QR Bill/Invoice 20th June 2020 Aug 27, 2019
@yvaucher
Copy link
Member

yvaucher commented Aug 27, 2019

Changed the date in the title for QR Invoice launch according to http://qr-bill.ch

@yvaucher yvaucher changed the title Swiss QR Bill/Invoice 20th June 2020 Swiss QR Bill/Invoice 20th June 2020 http://qr-bill.ch Aug 27, 2019
@oco-odoo
Copy link

I'm currently refactoring QR codes in master (so, Swiss ones as well). In the meantime, I'll update the implementation to match the latest version of the specification. Once it's done, I'll do the same in stable releases.

I'll probably have a few questions in the upcoming days, so that were sure to cover all the different use cases, so stay tuned ;)

@yvaucher yvaucher pinned this issue Feb 6, 2020
@Guisolan
Copy link

Guisolan commented Jul 16, 2020 via email

@Martronic-SA
Copy link
Contributor

@Guisolan

bank reference field is not automatically updated (we have develop shot
module to do it) meanwhile that OCA enhance this point

Is that related to that issue? OCA/bank-payment#720

@Guisolan
Copy link

Guisolan commented Jul 20, 2020 via email

@yvaucher
Copy link
Member

@Guisolan

We don't have develop v13 because QR-Bill is deliver within l10n_ch.

Well sort of, I'm well aware of this as I gave insights and proposed patches to Odoo team to fix it in v13 and spent hours on this. As explained in previous comments. Now It's pretty decent. Will see, soon, if there are still few glitches.

Be aware that Odoo is backporting the report to v12 in l10n_ch. Should work for your module if you keep the official report hidden. (should still be hidden by default)

About the 27 char ref, also known as QRR, it must only be printed in Reference field if it is associated with a QR-IBAN, otherwise it can sort of be passed in "Additional info" as it won't be considered as a structured reference.

bank reference field is not automatically updated (we have develop shot
module to do it) meanwhile that OCA enhance this point
I don't understand this point. I believe you are talking about the the v13 official module? How is it related to the OCA?
If not already done could you report the issue somewhere?

@SimoRubi
Copy link
Member

New update on Swiss QR-bill generation:

For v10: https://github.com/OCA/l10n-switzerland/tree/10.0/l10n_ch_qr_bill
For v11 it needs to be ported and hosted in OCA/l10n-switzerland (from v10 as it already makes the module separately)
For v12 we have to wait on Odoo to finalize it: odoo/odoo#54427
For v13 it is available in l10n_ch with 2 ongoing fixes for margin issues odoo/odoo#54383

Update for v12: odoo/odoo#54427 is merged 🎉

@thomich
Copy link

thomich commented Jul 23, 2020

testing around on Odoo 10 with l10n_ch_qr_bill:

duplicate partner_bank_id in invoice/other info:
https://github.com/OCA/l10n-switzerland/blob/10.0/l10n_ch_qr_bill/views/account_invoice_view.xml#L16

results in:
image

@yvaucher
Copy link
Member

@thomich AFAIK the field partner_bank_id is invisible in Odoo CE. So we have to change that to make it visible instead of adding the field a second time. In your case you see twice the field maybe because an other module already makes the field visible?

In any case you are right it's a bug even with an invisible field.

https://github.com/odoo/odoo/blob/10.0/addons/account/views/account_invoice_view.xml#L465

@yvaucher
Copy link
Member

@thomich review welcome on #555

It should fix the partner bank field issue.

@thomich
Copy link

thomich commented Jul 27, 2020

@thomich review welcome on #555

It should fix the partner bank field issue.

hey @yvaucher
thanks... looks great

another question...
it will generate a new QRR (reference) which is the uid used for the payment of the customer, right?
with ISR (BVR) we also have a ref which is in bank camt file we import to reconcile invoice moves.
has the camt import method also changed as we have new QRR and field for QRR is l10n_ch_qrr / l10n_ch_qrr_spaced.

Thanks for clearify.

Regards
thomi

@yvaucher
Copy link
Member

@thomich yes the QRR becomes the new payment reference. It's intentionally the same format as the ISR (27 chars).

Reconciliation must be done on it. It should already work on v12 and v13. The point you raise looks to me that in v10 we probably still need to copy it on the transaction_id field. Which means we are missing an additional module.

BTW, be aware that a QR-IBAN is usually an alias for an IBAN account. Thus for reconciliation you might need to reconcile the statement of the IBAN on the QR-IBAN. I haven't seen a camt about it, yet so I don't know if we will have to tweak something more if you use both the QR-IBAN and the IBAN of your bank account. I expect it to work without issue if you use this bank account only with QR-IBAN, until I'm proven wrong. As Odoo doesn't support any kind of alias bank account for the same account.

@thomich
Copy link

thomich commented Jul 28, 2020

hey @yvaucher

thanks for reply...

@thomich yes the QRR becomes the new payment reference. It's intentionally the same format as the ISR (27 chars).

👍

Reconciliation must be done on it. It should already work on v12 and v13. The point you raise looks to me that in v10 we probably still need to copy it on the transaction_id field. Which means we are missing an additional module.

means that in v10 special method will be made to copy QRR to transaction_id?

BTW, be aware that a QR-IBAN is usually an alias for an IBAN account. Thus for reconciliation you might need to reconcile the statement of the IBAN on the QR-IBAN. I haven't seen a camt about it, yet so I don't know if we will have to tweak something more if you use both the QR-IBAN and the IBAN of your bank account. I expect it to work without issue if you use this bank account only with QR-IBAN, until I'm proven wrong. As Odoo doesn't support any kind of alias bank account for the same account.

yeah... it is really confusing... also for our customers...

one other thing i found:
if you print the QR-Invoice, it will not give any file extension, which can cause problems on some client systems.
it's a PDF, but with out .pdf extension..

regards
thomi

@yvaucher
Copy link
Member

@thomich Thank you for the feed back.

Here are 2 PRs that should resolves the following issues:

@thomich
Copy link

thomich commented Aug 10, 2020

hey @yvaucher

man thanks for your work... tested and looks very nice...
have made the german translation... i know, i could make a PR and so on, but think if you integrate it, it's faster.. ;)

pm me please, then i can send you the de.po file...

again, many thanks
thomi

@stevech091
Copy link

Hello,
I have made italian translation on Weblate.
Regards

@yvaucher
Copy link
Member

yvaucher commented Aug 14, 2020

@thomich the proper way to push translation on OCA modules is through Weblate.

https://translation.odoo-community.org/projects/l10n-switzerland-10-0/

We have a bot that will automate the push on github.
IIRC Weblate suports import a PO file, but it seems deactivated, maybe a translator with enough admin rights can do it if you have numerous terms to translate.

@yvaucher
Copy link
Member

@stevech091 Great! Grazie !

@thomich
Copy link

thomich commented Aug 17, 2020

@thomich the proper way to push translation on OCA modules is through Weblate.

https://translation.odoo-community.org/projects/l10n-switzerland-10-0/

We have a bot that will automate the push on github.
IIRC Weblate suports import a PO file, but it seems deactivated, maybe a translator with enough admin rights can do it if you have numerous terms to translate.

Hey @yvaucher

thx, will do that.... will translations then also be ported to other version's? 11, 12, 13?

regards
thomi

@yvaucher
Copy link
Member

@thomich for the QR-bill for 12 and 13 it doesn't exists in OCA, it's in odoo CE

You want to have a look at https://github.com/odoo/odoo/wiki/Translations

@thomich
Copy link

thomich commented Aug 18, 2020

@yvaucher what about QR-bill and 11.0?

thanks for information about translation, will make it soon ;)

thomi

@thomich
Copy link

thomich commented Aug 20, 2020

@thomich the proper way to push translation on OCA modules is through Weblate.

https://translation.odoo-community.org/projects/l10n-switzerland-10-0/

We have a bot that will automate the push on github.
IIRC Weblate suports import a PO file, but it seems deactivated, maybe a translator with enough admin rights can do it if you have numerous terms to translate.

Hey @yvaucher
have registered @ weblate but can't make translations or even suggest. I also contacted [email protected] but not getting any notification/feedback.

Here is my de.po file.... if you can do it with a PR... would be nice.. and THANKS
de.tar.gz

regards
thomi

@philhug
Copy link

philhug commented Sep 10, 2020

Is anyone working on adding Creditor Reference (SCOR) support instead of QRR?
It uses the normal IBAN account number + a standard ISO 11649 reference (starting with RF...) instead of a separate QR-IBAN

https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf

@yvaucher
Copy link
Member

@philhug the official odoo module does not support Creditor Reference. And I strongly doubt that Odoo will do it any time soon.

On my side I have no ongoing implementation on this topic.
Shouldn't be too complicated to add though. We have to propose that to the official module. In hope they don't only accept it in version 14.0.

@yvaucher
Copy link
Member

FYI odoo/odoo#55571 has been merged.

It includes a new module l10n_ch_qriban which adds a field on res.partner.bank to store the QR-IBAN.
This aims to allows reconciliation using both the IBAN and the QR-IBAN with the in-payments.

cc @thomich

@R3D2
Copy link

R3D2 commented Nov 26, 2020

Hey ! I tried to migrate the module to V11, it seems to work fine. I'm really new to contributing, I will be glad to have my code reviewed. https://github.com/R3D2/l10n_ch_qr_bill

@thomich
Copy link

thomich commented Nov 26, 2020

Hey ! I tried to migrate the module to V11, it seems to work fine. I'm really new to contributing, I will be glad to have my code reviewed. https://github.com/R3D2/l10n_ch_qr_bill

Hey @R3D2

Thanks for your contribution.

Check license, as i know, it should keep the original license from Odoo 13: LGPL-3
Check if license is everywhere the same ;)

Regards
thomi

@yvaucher
Copy link
Member

yvaucher commented Dec 8, 2020

@R3D2 can you push it as a pull request in this repository on branch 11.0 to allow us to review it ?

@gfrino
Copy link

gfrino commented Jun 29, 2021

We at ticinoWEB have developed module for Odoo v10 https://apps.odoo.com/apps/modules/10.0/invoice_ch_qr_slip/ and a fix for Odoo QR Bill for v14 https://apps.odoo.com/apps/modules/14.0/generate_inv_qr/

The v14 fixes this error: The following error prevented 'Swiss QR bill' QR-code to be generated though it was detected as eligible: When using a QR-IBAN as the destination account of a QR-code, the payment reference must be a QR-reference.

Our module will automatically generate the payment reference

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odoo_core_related stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests