-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] hr_attendance_validation: Ignoring some leave types #155
Conversation
73062e3
to
8688b25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm: code review
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hello @OCA/human-resources-maintainers , please could you reopen this PR? Thank you! 🙏🏼 |
Hello @petrus-v , I you are the author of this module, you can add your self as maintainter so you can merge your self Do you know about it? Regards ✋🏼 |
Sorry for noise, @nimarosa could you reopen and merge? |
/ocabot rebase @rafaelbn lets rebase first so we check the tests passes. Then we can merge. |
we are using hr.leaves to manage allowed remote days but we don't want to remove thoses times in attendance validation
Congratulations, PR rebased to 14.0. |
8688b25
to
6ccca01
Compare
On my way to merge this fine PR! |
Congratulations, your PR was merged at 35ea8b8. Thanks a lot for contributing to OCA. ❤️ |
Thanks @rafaelbn to make this merge possible ! Yes, sometimes I try to put myself as maintainer but I've never use the |
we are using hr.leaves to manage allowed remote days but we don't want to remove thoses times in attendance validation