[16.0][IMP] resource_booking: Reduce and simplify code according to https://github.com/odoo/odoo/pull/174494/commits/d7bbcefd4002dda07e06b89b4bc69b80c8e338fd #138
Conversation
|
Hi @pedrobaeza, @ows-cloud, |
|
This must be merged, as now tests are broken: /ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-138-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-138-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@victoralmau can you check the failing? |
victoralmau
force-pushed
the
16.0-imp-resource_booking-misc
branch
from
43c2c35 to
2cef0d9
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-138-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
d7bbcef The changes added at OCA@851dc9a and OCA@a3cd5a8 are unnecessary according to the approach added at odoo/odoo@d7bbcef. We maintain the tests to confirm that the expected behavior is maintained.
victoralmau
force-pushed
the
16.0-imp-resource_booking-misc
branch
from
2cef0d9 to
a1e51d9
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at dc9aa49. Thanks a lot for contributing to OCA. ❤️ |
Reduce and simplify code according to odoo/odoo@d7bbcef
The changes added at 851dc9a and a3cd5a8 are unnecessary according to the approach added at odoo/odoo@d7bbcef. We maintain the tests to confirm that the expected behavior is maintained.
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa