[15.0][IMP] resource_booking: No create/unlink call if nothing to do #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on how the create/unlink overrides are programmed, there can be overheads or blocking things when calling unconditionally these methods, even with an empty list, so let's only call them when there is really something to delete or to create. This has been discovered as `google_calendar` module is calling Google API on calendar event create (although vals_list being empty), and due to an error with Google API right now, I was not able to create a draft resource booking.
carolinafernandez-tecnativa
approved these changes
Jan 5, 2024
victoralmau
approved these changes
Jan 5, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 448f051. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how the create/unlink overrides are programmed, there can be overheads or blocking things when calling unconditionally these methods, even with an empty list, so let's only call them when there is really something to delete or to create.
This has been discovered as
google_calendarmodule is calling Google API on calendar event create (although vals_list being empty), and due to an error with Google API right now, I was not able to create a draft resource booking.@Tecnativa