Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_move_reconcile_forbid_cancel: Migration to 16.0 #568

Merged
merged 14 commits into from
Aug 31, 2023
Merged

[16.0][MIG] account_move_reconcile_forbid_cancel: Migration to 16.0 #568

merged 14 commits into from
Aug 31, 2023

Conversation

ACheung-FactorLibre
Copy link
Contributor

No description provided.

@ACheung-FactorLibre ACheung-FactorLibre marked this pull request as draft July 19, 2023 08:41
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-mig-account_move_reconcile_forbid_cancel branch from 3e3ec77 to 8a01615 Compare July 19, 2023 09:26
@ACheung-FactorLibre ACheung-FactorLibre changed the title [WIP][16.0][MIG] account_move_reconcile_forbid_cancel [16.0][MIG] account_move_reconcile_forbid_cancel Jul 19, 2023
@ACheung-FactorLibre ACheung-FactorLibre marked this pull request as ready for review July 19, 2023 09:37
@ACheung-FactorLibre ACheung-FactorLibre changed the title [16.0][MIG] account_move_reconcile_forbid_cancel [16.0][MIG] account_move_reconcile_forbid_cancel: Migration to 16.0 Jul 19, 2023
@ACheung-FactorLibre
Copy link
Contributor Author

Issue #497

RodrigoBM
RodrigoBM suggested changes Jul 19, 2023
View reviewed changes
Copy link

@RodrigoBM RodrigoBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try it?

account_move_reconcile_forbid_cancel/models/account_move.py Outdated Show resolved Hide resolved
account_move_reconcile_forbid_cancel/models/account_move.py Outdated Show resolved Hide resolved
account_move_reconcile_forbid_cancel/models/account_move.py Outdated Show resolved Hide resolved
account_move_reconcile_forbid_cancel/models/account_move.py Outdated Show resolved Hide resolved
account_move_reconcile_forbid_cancel/models/account_move.py Outdated Show resolved Hide resolved
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-mig-account_move_reconcile_forbid_cancel branch from 8a01615 to f886cae Compare July 19, 2023 12:18
@ACheung-FactorLibre
Copy link
Contributor Author

Thank you @RodrigoBM

@RodrigoBM
Copy link

RodrigoBM commented Jul 19, 2023 •
edited
Loading

have @adrianojprado added this translation?

https://github.com/OCA/account-reconcile/blame/16.0/account_move_base_import/i18n/pt_BR.po#L36

this is wrong, it will have to be "%(log)s\n"

@RodrigoBM
Copy link

RodrigoBM commented Jul 21, 2023 •
edited
Loading

have @adrianojprado added this translation?

https://github.com/OCA/account-reconcile/blame/16.0/account_move_base_import/i18n/pt_BR.po#L36

this is wrong, it will have to be "%(log)s\n"

ping @adrianojprado

https://translation.odoo-community.org/translate/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/?checksum=1ec4daeaeafa847c

%(completion_date)s A movimentação da conta %(move_name)s tem %(num_imported)s/%(number_line)s linhas concluídas por %(user_name)s
%(error_msg)s
%(log)s\n

@RodrigoBM
Copy link

have @adrianojprado added this translation?
https://github.com/OCA/account-reconcile/blame/16.0/account_move_base_import/i18n/pt_BR.po#L36
this is wrong, it will have to be "%(log)s\n"

ping @adrianojprado

https://translation.odoo-community.org/translate/account-reconcile-16-0/account-reconcile-16-0-account_move_base_import/pt_BR/?checksum=1ec4daeaeafa847c

%(completion_date)s A movimentação da conta %(move_name)s tem %(num_imported)s/%(number_line)s linhas concluídas por %(user_name)s
%(error_msg)s
%(log)s\n

Thanks @adrianojprado

@ACheung-FactorLibre Can you rebase plase

Ernesto Tejeda and others added 13 commits July 25, 2023 17:39
@ACheung-FactorLibre
[ADD] account_move_reconcile_forbid_cancel: new module
daad85a 
[UPD] Update account_move_reconcile_forbid_cancel.pot

[UPD] README.rst

[ADD] icon.png
@ernestotejeda @ACheung-FactorLibre
Translated using Weblate (Spanish)
fab0de8 
Currently translated at 100.0% (3 of 3 strings)

Translation: account-reconcile-13.0/account-reconcile-13.0-account_move_reconcile_forbid_cancel
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-13-0/account-reconcile-13-0-account_move_reconcile_forbid_cancel/es/
@ACheung-FactorLibre
[FIX] account_move_reconcile_forbid_cancel: make it compatible with t…
e7ef078 
…est of other modules
@ACheung-FactorLibre
[FIX] account_move_reconcile_forbid_cancel: wrong payable acc detecti…
c856cad 
…on and add test.

account_move_reconcile_forbid_cancel 13.0.1.0.1
@carlosdauden @ACheung-FactorLibre
[IMP] account_move_reconcile_forbid_cancel: Add context to skip restr…
d0b6d70 
…iction (P.E. payment orders)

TT38927 TT39037

account_move_reconcile_forbid_cancel 13.0.1.0.2
@victoralmau @ACheung-FactorLibre
[IMP] account_move_reconcile_forbid_cancel: black, isort, prettier
6101ff7
@victoralmau @ACheung-FactorLibre
[MIG] account_move_reconcile_forbid_cancel: Migration to 15.0
ea57967 
TT40142
@ACheung-FactorLibre
[UPD] Update account_move_reconcile_forbid_cancel.pot
91de3cf
@OCA-git-bot @ACheung-FactorLibre
[UPD] README.rst
658dec4
@weblate @ACheung-FactorLibre
Update translation files
2fef342 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-15.0/account-reconcile-15.0-account_move_reconcile_forbid_cancel
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-15-0/account-reconcile-15-0-account_move_reconcile_forbid_cancel/
@douglascstd @ACheung-FactorLibre
Added translation using Weblate (Portuguese (Brazil))
aaea840
@douglascstd @ACheung-FactorLibre
Translated using Weblate (Portuguese (Brazil))
5542e7d 
Currently translated at 100.0% (3 of 3 strings)

Translation: account-reconcile-15.0/account-reconcile-15.0-account_move_reconcile_forbid_cancel
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-15-0/account-reconcile-15-0-account_move_reconcile_forbid_cancel/pt_BR/
@ACheung-FactorLibre
[IMP] account_move_reconcile_forbid_cancel: pre-commit stuff
abed5c1
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-mig-account_move_reconcile_forbid_cancel branch from f886cae to 2652f02 Compare July 25, 2023 15:39
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-mig-account_move_reconcile_forbid_cancel branch from 2652f02 to fb7e9d2 Compare July 26, 2023 06:59
Gelo-fl
Gelo-fl approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Gelo-fl Gelo-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM https://www.awesomescreenshot.com/video/20375290?key=b64ee17bd28e1df04f1fd0807e9f7ae2

@pedrobaeza
Copy link
Member

/ocabot migration account_move_reconcile_forbid_cancel
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 31, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-568-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 20, 2023
Open
5 tasks
@OCA-git-bot OCA-git-bot merged commit 30f303a into OCA:16.0 Aug 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ce98136. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-account_move_reconcile_forbid_cancel branch September 4, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gelo-fl Gelo-fl Gelo-fl approved these changes

@ikedetoro ikedetoro ikedetoro approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.