Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][14.0]account_loan: add loan lines menu item #1730

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[IMP][14.0]account_loan: add loan lines menu item #1730

merged 1 commit into from
Oct 3, 2023

Conversation

odooNextev
Copy link

@odooNextev odooNextev commented Sep 29, 2023 •
edited
Loading

No description provided.

@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch from b190d7f to 3a19a8c Compare September 29, 2023 13:23
bosd
bosd approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM 👍

@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch 2 times, most recently from a1eeb27 to ae10a41 Compare October 2, 2023 09:54
@odooNextev odooNextev changed the title [IMP][14.0]Loan lines menu item to get tree,pivot and graph views for loan … [IMP][14.0]account_loan: add loan lines menu item Oct 2, 2023
@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch 3 times, most recently from df92808 to adc87c7 Compare October 2, 2023 14:56
francesco-ooops
francesco-ooops approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

Added loan items menu with pivot and graph for loan analysis.

@francesco-ooops
Copy link
Contributor

@AaronHForgeFlow since I saw you recently merged the v16 migration, is this ok? we can then forward-port it.

@AaronHForgeFlow
Copy link
Contributor

For me it is fine. WDYT @etobella ?

etobella
etobella reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. Can you do something like this https://github.com/odoo/odoo/blob/14.0/addons/account/views/account_move_views.xml#L201-L207 in order to improve even more the view 😄

@francesco-ooops
Copy link
Contributor

francesco-ooops commented Oct 3, 2023 •
edited
Loading

Hi @etobella , what is it that you suggest to change functionally?

AFAICS it's not currently possible to edit loan items from loan form

@etobella
Copy link
Member

etobella commented Oct 3, 2023

No, no, I just wanted to add an access to the loan 😄

@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch from adc87c7 to 7a56e8b Compare October 3, 2023 12:30
@odooNextev
Copy link
Author

Now, clicking on the loan name it will open loan form view.

etobella
etobella reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not talking about this. I was looking for something like this:

This would add an edit button to access the loan when grouping by loan 😄

account_loan/views/account_loan_lines_view.xml
<field name="short_term_loan_account_id" optional="hide" />
<field name="long_term_loan_account_id" optional="hide" />
<field name="interest_expenses_account_id" optional="hide" />
</tree>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</tree>
<groupby name="loan_id">
<button name="edit" type="edit" icon="fa-edit" title="Edit"/>
</groupby>
</tree>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advices. Now it shown the edit button when grouping.

account_loan/views/account_loan_lines_view.xml Outdated
<field name="name">account.loan.lines.view</field>
<field name="model">account.loan.line</field>
<field name="arch" type="xml">
<tree create="0" import="0" editable="bottom">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add this. It might be a problem to edit the information

@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch from 7a56e8b to 32fb458 Compare October 3, 2023 13:57
@etobella
Copy link
Member

etobella commented Oct 3, 2023 •
edited
Loading

Thanks, as you are adding a menu, can you add a new parent menu to join them? Now it looks like this:

image

Sorry to ask so much, but I think we can improve it with just a small change.

@odooNextev odooNextev force-pushed the 14.0-impr-account_loan branch from 32fb458 to 0dc48fc Compare October 3, 2023 14:16
etobella
etobella approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

Can you port it to 16? Module has not been migrated to 15

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1730-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8f9f653 into OCA:14.0 Oct 3, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 789f3d5. Thanks a lot for contributing to OCA. ❤️

@etobella etobella mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@etobella etobella etobella approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@odooNextev @francesco-ooops @AaronHForgeFlow @etobella @OCA-git-bot @bosd @GSLabIt @matteonext