Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_move_line_tax_editable: Migration to 16.0 #1508

Merged
merged 18 commits into from
May 24, 2023
Merged

[16.0][MIG] account_move_line_tax_editable: Migration to 16.0 #1508

merged 18 commits into from
May 24, 2023

Conversation

ljsalvatierra-factorlibre
Copy link
Contributor

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre commented Nov 28, 2022 •
edited
Loading

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Nov 28, 2022
Open
33 tasks
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_move_line_tax_editable branch 3 times, most recently from e3fb663 to b859c23 Compare November 28, 2022 14:56
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_move_line_tax_editable branch from b859c23 to f188470 Compare December 22, 2022 09:03
@rafaelbn
Copy link
Member

/ocabot migration account_move_line_tax_editable

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 23, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2023
Closed
@pedrobaeza
Copy link
Member

pedrobaeza commented Apr 4, 2023 •
edited
Loading

/ocabot migration account_move_line_tax_editable

TT42385

@OCA-git-bot
Copy link
Contributor

The migration issue (#1472) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1629.
Perhaps you should check that there is no duplicate work.
CC : @Yadier-Tecnativa

Yadier-Tecnativa
Yadier-Tecnativa suggested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@Yadier-Tecnativa Yadier-Tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

account_move_line_tax_editable/i18n/es.po Outdated Show resolved Hide resolved
@Yadier-Tecnativa
Copy link
Contributor

Tested locally

@pedrobaeza
Copy link
Member

Please squash latest commit for merging this

benwillig and others added 12 commits May 24, 2023 09:26
@benwillig @ljsalvatierra-factorlibre
[10.0][ADD] Module to allow account move line taxes edition
f31aed7
@benwillig @ljsalvatierra-factorlibre
[IMP] Taxes data should not be editable if linked move is not in draft
28ec8fe
@ljsalvatierra-factorlibre
Migrate account_move_line_tax_ediatble to 11.0
9b5a36a 
Update __manifest__.py
@rschnapka @ljsalvatierra-factorlibre
Translated using Weblate (German)
3ccd0df 
Currently translated at 100,0% (2 of 2 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_move_line_tax_editable
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_move_line_tax_editable/de/
@ernestotejeda @ljsalvatierra-factorlibre
[MIG] account_move_line_tax_editable: Migration to 12.0
6ad16fd
@pedrocs-exo @ljsalvatierra-factorlibre
Added translation using Weblate (Portuguese)
87984b0
@MiquelRForgeFlow @ljsalvatierra-factorlibre
[IMP] account_move_line_tax_editable: black, isort
2a06faa
@MiquelRForgeFlow @ljsalvatierra-factorlibre
[MIG] account_move_line_tax_editable: Migration to 13.0
e2056d8
@HviorForgeFlow @ljsalvatierra-factorlibre
[FIX] account_move_line_tax_editable:
ec27311 
* [FIX] Do not hide Originator Tax
* [IMP] Add optional hide option to Originator Tax
* [FIX] Drop tax_ids field from Journal Item page, as it is already displayed.
@OCA-git-bot @ljsalvatierra-factorlibre
account_move_line_tax_editable 13.0.1.1.0
75b8214
@Zar21 @ljsalvatierra-factorlibre
[MIG] account_move_line_tax_editable: Migration to 14.0
e3d4cf8
@mariadforgeflow @ljsalvatierra-factorlibre
[FIX] account_move_line_tax_editable: make tax field actually editable
e16e3ad
OCA-git-bot and others added 6 commits May 24, 2023 09:26
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_move_line_tax_editable branch from ffdb42f to 580a8d2 Compare May 24, 2023 07:27
@ljsalvatierra-factorlibre
Copy link
Contributor Author

Please squash latest commit for merging this

Done :)

@Yadier-Tecnativa is it ok?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1508-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 15f19f1 into OCA:16.0 May 24, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 91d7d49. Thanks a lot for contributing to OCA. ❤️

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre deleted the 16.0-mig-account_move_line_tax_editable branch May 24, 2023 08:20
@patrickkappertqubiq
Copy link

Hello, is there a specific configuration? I installed in 16 and Odoo keeps calculating the tax and does not permit edit the amount of the tax at the journal entry.

@pedrobaeza
Copy link
Member

This is not for editing the amount. Just the fields tax_line_id and tax_ids.

@patrickkappertqubiq
Copy link

Ok, thanks.

We leave the balance line with import 0 without deleting and while this line exist odoo does not calculate again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadier-Tecnativa Yadier-Tecnativa Yadier-Tecnativa requested changes

@pedrobaeza pedrobaeza pedrobaeza left review comments

@astirpe astirpe astirpe approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.