[16.0][MIG] account_asset_management: Migration to 16.0 #1479

RodrigoBM · 2022-10-17T16:43:55Z

RodrigoBM · 2022-10-17T17:28:27Z

pre-commit fails for double duplicate field, but I need this one in V16 for groups="base.group_multi_company" or I haven't migrated the view properly.

RodrigoBM · 2022-10-17T17:29:06Z

/ocabot migration account_asset_management

OCA-git-bot · 2022-10-17T17:29:14Z

Sorry @RodrigoBM you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza · 2022-10-17T18:07:45Z

/ocabot migration account_asset_management

account_asset_management/views/account_asset_group.xml

pedrobaeza

All the analytic stuff is not correctly ported.

account_asset_management/models/account_asset.py

pedrobaeza · 2022-10-19T06:14:23Z

account_asset_management/models/account_asset.py

-        asset = super().create(vals)
+    @api.model_create_multi
+    def create(self, vals_list):
+        asset = super().create(vals_list)


This returns several records, so you have to take it into account.

i think its ok now

pedrobaeza · 2022-10-19T06:18:15Z

account_asset_management/models/account_asset_line.py

            "date": depreciation_date,
            "asset_id": asset.id,
        }
+        if analytic_id:
+            move_line_data["analytic_distribution"][analytic_id] = 100


This is not the same thing as the previous tags.

i think its ok now

pedrobaeza · 2022-10-19T06:18:27Z

account_asset_management/models/account_asset_profile.py

@@ -16,9 +16,6 @@ class AccountAssetProfile(models.Model):
    account_analytic_id = fields.Many2one(
        comodel_name="account.analytic.account", string="Analytic account"
    )
-    analytic_tag_ids = fields.Many2many(


Replace it by the corresponding feature

pedrobaeza · 2022-10-19T06:19:04Z

account_asset_management/models/account_asset_profile.py

+        for vals in vals_list:
+            if vals.get("method_time") != "year" and not vals.get("prorata"):
+                vals["prorata"] = True
+        profile = super().create(vals_list)


This returns several records. Take it into account.

i think its ok now

account_asset_management/models/account_move.py

account_asset_management/report/account_asset_report_xls.py

pedrobaeza · 2022-10-19T06:20:24Z

account_asset_management/tests/test_account_asset_management.py

        self.assertEqual(ict0.state, "open")
        self.assertEqual(ict0.value_depreciated, 500)
        self.assertEqual(ict0.value_residual, 1000)
        vehicle0.validate()
-        created_move_ids = vehicle0.depreciation_line_ids[1].create_move()
-        for move_id in created_move_ids:


Keep these asserts

pedrobaeza · 2022-10-19T06:22:13Z

account_asset_management/views/account_move.xml

@@ -4,7 +4,6 @@
        <field name="name">account.move.form.account.asset.management</field>
        <field name="model">account.move</field>
        <field name="inherit_id" ref="account.view_move_form" />
-        <field name="groups_id" eval="[(4, ref('account.group_account_invoice'))]" />


The rest of the fields should have the group as well.

i think its ok now

FernandoRomera

Functional test with runboat, Ok.

fcvalgar

Functional review is ok.

Review Asset Profile V16 and this model work fine.

FernandoRomera · 2022-12-20T10:12:41Z

@pedrobaeza
Can you merge this PR, please?

rafaelbn · 2022-12-22T17:38:06Z

Hello @pedrobaeza , I think you comments have been attended. Thanks!

account_asset_management/models/account_asset_line.py

add asset management modules asset mgt update redo synch asset mgt with recent V7 changes

[UPD] add places arg in assertAlmostEqual tests [UPD] flake clean

Currently translated at 98.8% (260 of 263 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_asset_management/es/

Currently translated at 100.0% (263 of 263 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_asset_management/es/

…ively When updating assets massively the performance when searching for deprecation_lines_ids is very low. It is a difficult problem to detect since massive asset updates are not common. Indexing in this field dramatically improves the timing performance. For example, to update 3000 records it took 30 sec. With this index it takes to 2 seconds.

RodrigoBM · 2022-12-24T01:24:30Z

Hi @fcvalgar @FernandoRomera

with the comment of @hieulucky111 i think is a good moment to add pr #1513 in this migration, is possible that your functional test again?

@pedrobaeza i add ref commit for change company_currency_id to currency_id and not to add currency_field option in monetary field.

Best regards

pedrobaeza

If you enter to the asset form without the analytic group, there's this error:

You are not allowed to access 'Analytic Plan's Applicabilities' (account.analytic.applicability) records.

This operation is allowed for the following groups:
	- Technical/Analytic Accounting

Contact your administrator to request access if necessary.

Please check the groups associated to the analytic fields.

pedrobaeza · 2022-12-27T19:46:17Z

account_asset_management/models/account_asset_line.py

-    amount = fields.Monetary(
-        string="Amount", required=True, currency_field="company_currency_id"
-    )
+    amount = fields.Monetary(required=True, currency_field="company_currency_id")


Please change also the currency on this model to currency_id and remove all the currency_field references. In fact, the related field should be to the asset currency, not to the company one (although right now is the same).

I did that in my commit [REF] account_asset_management: the name of the company_currency_id. didn't know if I should apply fixup with commit MIG.

RodrigoBM · 2022-12-28T19:43:27Z

If you enter to the asset form without the analytic group, there's this error:
You are not allowed to access 'Analytic Plan's Applicabilities' (account.analytic.applicability) records.

This operation is allowed for the following groups:
	- Technical/Analytic Accounting

Contact your administrator to request access if necessary.
Please check the groups associated to the analytic fields.

I added group_analytic_accounting to analytic_distribution field.

Thanks

hieulucky111

LGTM.

fcvalgar · 2023-01-02T10:06:34Z

Now I detect an error when I apply an asset profile on the invoice line @RodrigoBM

https://www.loom.com/share/c172198b9acd429da5e35f5400513a9f

@moduon MT-1849

…ield is changed to currency_id and currency_field is not required.

RodrigoBM · 2023-01-04T15:17:24Z

Now I detect an error when I apply an asset profile on the invoice line @RodrigoBM

https://www.loom.com/share/c172198b9acd429da5e35f5400513a9f

@moduon MT-1849

I have already solved the bug. Thank you @fcvalgar

pedrobaeza

Thanks, Rodrigo!

/ocabot merge nobump

OCA-git-bot · 2023-01-06T12:13:29Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1479-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-06T12:19:33Z

Congratulations, your PR was merged at 03be733. Thanks a lot for contributing to OCA. ❤️

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch 2 times, most recently from cd24bae to c2ec97d Compare October 17, 2022 17:18

OCA-git-bot added this to the 16.0 milestone Oct 17, 2022

OCA-git-bot mentioned this pull request Oct 17, 2022

Migration to version 16.0 #1472

Open

33 tasks

pedrobaeza reviewed Oct 17, 2022

View reviewed changes

account_asset_management/views/account_asset_group.xml Show resolved Hide resolved

moylop260 mentioned this pull request Oct 18, 2022

xml_duplicate_fields: Support special case for 'Duplicate xml field "company_id"' OCA/odoo-pre-commit-hooks#10

Closed

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch from c2ec97d to 828063f Compare October 18, 2022 20:26

pedrobaeza requested changes Oct 19, 2022

View reviewed changes

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch 4 times, most recently from 009253b to b75a3b7 Compare October 20, 2022 11:19

RodrigoBM changed the title ~~[16.0] [MIG] account_asset_management~~ [16.0][MIG] account_asset_management: Migration to 16.0 Dec 4, 2022

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch 2 times, most recently from cf7a976 to a6b03ad Compare December 9, 2022 16:28

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch 2 times, most recently from 62f6a80 to 8637ac4 Compare December 12, 2022 16:09

FernandoRomera approved these changes Dec 17, 2022

View reviewed changes

fcvalgar approved these changes Dec 19, 2022

View reviewed changes

rafaelbn added the needs review label Dec 22, 2022

hieulucky111 reviewed Dec 23, 2022

View reviewed changes

account_asset_management/models/account_asset_line.py Outdated Show resolved Hide resolved

hieulucky111 reviewed Dec 23, 2022

View reviewed changes

account_asset_management/models/account_asset_line.py Outdated Show resolved Hide resolved

lepistone and others added 2 commits December 24, 2022 00:42

move account_asset_management* out of __unported__

99560a0

add asset management modules asset mgt update redo synch asset mgt with recent V7 changes

[FIX] test floats with assertAlmostEqual

7bd04de

[UPD] add places arg in assertAlmostEqual tests [UPD] flake clean

angel and others added 7 commits December 24, 2022 00:42

[15.0][FIX] account_asset_management: add post-install tagged.

2800a99

account_asset_management 15.0.1.0.1

fae4175

[MIG] account_asset_management_menu: Migration to 15.0

82f0144

[UPD] README.rst

e1d170d

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch from 8637ac4 to 2e07ed4 Compare December 23, 2022 23:43

[IMP] : pre-commit stuff

3c5d26b

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch from 2e07ed4 to 73b3200 Compare December 24, 2022 01:12

FernandoRomera approved these changes Dec 27, 2022

View reviewed changes

pedrobaeza requested changes Dec 27, 2022

View reviewed changes

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch from 73b3200 to c176383 Compare December 28, 2022 19:35

hieulucky111 approved these changes Dec 30, 2022

View reviewed changes

RodrigoBM added 2 commits January 4, 2023 16:07

[MIG] account_asset_management: Migration to 16.0

f1371e5

[REF] account_asset_management: the name of the company_currency_id f…

12a018d

…ield is changed to currency_id and currency_field is not required.

RodrigoBM force-pushed the 16.0-mig-account_asset_management branch from c176383 to 12a018d Compare January 4, 2023 15:07

pedrobaeza approved these changes Jan 6, 2023

View reviewed changes

OCA-git-bot added the approved label Jan 6, 2023

OCA-git-bot added the bot is merging ⏳ label Jan 6, 2023

OCA-git-bot merged commit 760f1a5 into OCA:16.0 Jan 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 6, 2023

RodrigoBM deleted the 16.0-mig-account_asset_management branch January 6, 2023 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_asset_management: Migration to 16.0 #1479

[16.0][MIG] account_asset_management: Migration to 16.0 #1479

RodrigoBM commented Oct 17, 2022 •

edited

Loading

RodrigoBM commented Oct 17, 2022

RodrigoBM commented Oct 17, 2022

OCA-git-bot commented Oct 17, 2022

pedrobaeza commented Oct 17, 2022

pedrobaeza left a comment

pedrobaeza Oct 19, 2022

RodrigoBM Oct 19, 2022

pedrobaeza Oct 19, 2022

RodrigoBM Oct 20, 2022 •

edited

Loading

pedrobaeza Oct 19, 2022

RodrigoBM Oct 20, 2022

pedrobaeza Oct 19, 2022

RodrigoBM Oct 19, 2022

pedrobaeza Oct 19, 2022

RodrigoBM Oct 20, 2022

pedrobaeza Oct 19, 2022

RodrigoBM Oct 19, 2022

FernandoRomera left a comment

fcvalgar left a comment

FernandoRomera commented Dec 20, 2022

rafaelbn commented Dec 22, 2022

RodrigoBM commented Dec 24, 2022

pedrobaeza left a comment

pedrobaeza Dec 27, 2022

RodrigoBM Dec 28, 2022

RodrigoBM commented Dec 28, 2022 •

edited

Loading

hieulucky111 left a comment

fcvalgar commented Jan 2, 2023 •

edited

Loading

RodrigoBM commented Jan 4, 2023

pedrobaeza left a comment

OCA-git-bot commented Jan 6, 2023

OCA-git-bot commented Jan 6, 2023

[16.0][MIG] account_asset_management: Migration to 16.0 #1479

[16.0][MIG] account_asset_management: Migration to 16.0 #1479

Conversation

RodrigoBM commented Oct 17, 2022 • edited Loading

RodrigoBM commented Oct 17, 2022

RodrigoBM commented Oct 17, 2022

OCA-git-bot commented Oct 17, 2022

pedrobaeza commented Oct 17, 2022

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RodrigoBM Oct 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FernandoRomera left a comment

Choose a reason for hiding this comment

fcvalgar left a comment

Choose a reason for hiding this comment

FernandoRomera commented Dec 20, 2022

rafaelbn commented Dec 22, 2022

RodrigoBM commented Dec 24, 2022

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RodrigoBM commented Dec 28, 2022 • edited Loading

hieulucky111 left a comment

Choose a reason for hiding this comment

fcvalgar commented Jan 2, 2023 • edited Loading

RodrigoBM commented Jan 4, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 6, 2023

OCA-git-bot commented Jan 6, 2023

RodrigoBM commented Oct 17, 2022 •

edited

Loading

RodrigoBM Oct 20, 2022 •

edited

Loading

RodrigoBM commented Dec 28, 2022 •

edited

Loading

fcvalgar commented Jan 2, 2023 •

edited

Loading