[16.0] [MIG] account_fiscal_year #1473

baimont · 2022-10-04T08:43:04Z

* Add contributors to README * try to find a FY start date according to the start date from choosen period * Unable to unlink a date_range with type fiscal_year * `fiscal_year` flag readonly * add menu to date_range under accounting section * remove method on object because it's the same as in file * unable to delete with flag 'fiscal_year' but can delete * clean __openerp__.py * account_fiscal_year version number

[MIG] Migrated module 'account_fiscal_year' to V10

[UPD] Update account_fiscal_year.pot

Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

This date.range.type in v11 have benn used in some cases. Then, when you migrate, you need to have this data or else delete its xmlid. We think it's better to keep it, because you may want to still use it.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_fiscal_year Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_fiscal_year/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_fiscal_year Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_fiscal_year/

Currently translated at 100.0% (20 of 20 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_fiscal_year Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_fiscal_year/it/

Currently translated at 80.0% (16 of 20 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_fiscal_year Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_fiscal_year/es/

oca-clabot · 2022-10-04T08:43:07Z

Hey @baimont, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Yung-Wa [email protected] (no github login found)
oca-ci [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

baimont · 2022-10-04T12:58:07Z

/ocabot migration account_fiscal_year

OCA-git-bot · 2022-10-04T12:58:31Z

Sorry @baimont you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

adrienpeiffer · 2022-10-04T13:09:00Z

/ocabot migration account_fiscal_year

robinkeunen

Not an expert in accounting but here is my review, nothing blocking.

robinkeunen · 2022-10-10T09:54:01Z

account_fiscal_year/i18n/fr_FR.po

@@ -0,0 +1,127 @@
+# Translation of Odoo Server.


Should this file be merged into fr.PO? It does not look like France-specific french.

I'm not sure this is the time and place to do this.
OCA uses weblate for translations, right? https://odoo-community.org/resources/translate

I never took the time to investigate weblate, I guess it is smart about that.

account_fiscal_year/models/account_fiscal_year.py

robinkeunen · 2022-10-10T10:42:09Z

account_fiscal_year/models/account_fiscal_year.py

+        intersection_domain = expression.OR(
+            [
+                intersection_domain_from,
+                intersection_domain_to,
+                intersection_domain_contain,
+            ]
+        )


This could be simplified to the last of these three domains

intersection_domain = expression.NOT( expression.OR([ # fiscal years without intersections ("date_to" < date_from), ("date_from" > date_to) ]) ) # equivalent to (Morgan's Law) intersection_domain = expression.NOT( expression.AND([ expression.NOT(("date_to" < date_from)), expression.NOT("date_from" > date_to) ]) ) # equivalent to intersection_domain = expression.NOT( expression.AND([ ("date_to" >= date_from), ("date_from" <= date_to), ]) )

but that may not be as human readable (matter of taste, I understand the last one) not the place for these changes.

the commit for this is c06c1bb

I wonder what @SimoRubi thinks of your comment

I actually had @SimoRubi just in front of me, he favors

intersection_domain = expression.NOT( expression.OR([ # fiscal years without intersections ("date_to" < date_from), ("date_from" > date_to) ]) )

@SimoRubi is no more active, I talked about it with @robinkeunen and yes I think I did it just for human readability.

@robinkeunen ok to let it this way in this pr then?
if you want to change it you can always open a pr for v14.0

fair enough 👌

account_fiscal_year/models/res_company.py

baimont · 2022-10-10T12:50:22Z

Not an expert in accounting but here is my review, nothing blocking.

Hi @robinkeunen, thanks for your review! I adapted the code or answered to your comments.

OCA-git-bot · 2022-10-19T20:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn · 2022-10-19T20:11:08Z

/ocabot merge patch

OCA-git-bot · 2022-10-19T20:11:14Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1473-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot · 2022-10-19T20:14:21Z

Congratulations, your PR was merged at 0b9ca72. Thanks a lot for contributing to OCA. ❤️

Gelo-fl · 2023-06-01T07:24:34Z

Hi @dreispt,

This module is merged, however the translations are locked:
account-financial-tools-16.0-account_fiscal_year

Can I know why?

Thanks in advance,

damdam-s and others added 30 commits October 4, 2022 09:37

[ADD] add module "account_fiscal_year"

8c7d766

[FIX] Tests

17230a8

OCA Transbot updated translations from Transifex

3946ee6

[10.0][MIGRATION] Migrated module 'account_fiscal_year' to V10 (OCA#407)

3ecb0a0

[MIG] Migrated module 'account_fiscal_year' to V10

OCA Transbot updated translations from Transifex

0061136

[MIG] account_fiscal_year: Migration to 11.

5c4bc3d

OCA Transbot updated translations from Transifex

2c2aec5

[UPD] Update account_fiscal_year.pot

Added translation using Weblate (Arabic)

975bc50

OCA Transbot updated translations from Transifex

858fe98

Added translation using Weblate (Danish)

f012f6a

[UPD] Update account_fiscal_year.pot

8d291ea

Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[ADD] icon.png

55ae916

ADD refactored account_fiscal_year

9bf7e99

[ADD] fiscalyear date.range.type data

1d4f7b2

This date.range.type in v11 have benn used in some cases. Then, when you migrate, you need to have this data or else delete its xmlid. We think it's better to keep it, because you may want to still use it.

[UPD] Update account_fiscal_year.pot

543d34e

[UPD] README.rst

464f3fe

Added translation using Weblate (Dutch)

f52652a

[13.0][MIG] account_fiscal_year

8b70b92

[UPD] Update account_fiscal_year.pot

c292c52

[UPD] README.rst

7929b1a

pre-commit update

7aa814c

[MIG] account_fiscal_year: Migration to 14.0

c06c1bb

account_fiscal_year: Date range dependency no more needed

6c80e69

[UPD] Update account_fiscal_year.pot

85e6eb8

[UPD] README.rst

a5c3ca5

account_fiscal_year 14.0.1.0.1

0f90603

Add multi-company ir.rule on account.fiscal.year

ab4288d

OCA-git-bot and others added 7 commits October 4, 2022 09:37

account_fiscal_year 14.0.1.1.1

08cffc1

[15.0][MIG] Account Fiscal Year

ea33558

[UPD] Update account_fiscal_year.pot

488c749

[UPD] README.rst

4e56e9b

Added translation using Weblate (Spanish)

2899ff9

OCA-git-bot added this to the 16.0 milestone Oct 4, 2022

OCA-git-bot mentioned this pull request Oct 4, 2022

Migration to version 16.0 #1472

Open

33 tasks

robinkeunen reviewed Oct 10, 2022

View reviewed changes

[MIG] account_fiscal_year: Migration to 16.0

005211d

baimont force-pushed the 16.0-mig-account_fiscal_year-bai branch from d2817fe to 005211d Compare October 10, 2022 12:36

robinkeunen approved these changes Oct 11, 2022

View reviewed changes

adrienpeiffer approved these changes Oct 19, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 19, 2022

OCA-git-bot added the bot is merging ⏳ label Oct 19, 2022

OCA-git-bot merged commit 5d32c55 into OCA:16.0 Oct 19, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] account_fiscal_year #1473

[16.0] [MIG] account_fiscal_year #1473

baimont commented Oct 4, 2022

oca-clabot commented Oct 4, 2022

baimont commented Oct 4, 2022

OCA-git-bot commented Oct 4, 2022

adrienpeiffer commented Oct 4, 2022

robinkeunen left a comment

robinkeunen Oct 10, 2022

baimont Oct 10, 2022

robinkeunen Oct 11, 2022

robinkeunen Oct 10, 2022

baimont Oct 10, 2022

robinkeunen Oct 10, 2022

SirTakobi Oct 10, 2022

baimont Oct 10, 2022

robinkeunen Oct 11, 2022

baimont commented Oct 10, 2022

OCA-git-bot commented Oct 19, 2022

rafaelbn commented Oct 19, 2022

OCA-git-bot commented Oct 19, 2022

OCA-git-bot commented Oct 19, 2022

Gelo-fl commented Jun 1, 2023

[16.0] [MIG] account_fiscal_year #1473

[16.0] [MIG] account_fiscal_year #1473

Conversation

baimont commented Oct 4, 2022

oca-clabot commented Oct 4, 2022

baimont commented Oct 4, 2022

OCA-git-bot commented Oct 4, 2022

adrienpeiffer commented Oct 4, 2022

robinkeunen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baimont commented Oct 10, 2022

OCA-git-bot commented Oct 19, 2022

rafaelbn commented Oct 19, 2022

OCA-git-bot commented Oct 19, 2022

OCA-git-bot commented Oct 19, 2022

Gelo-fl commented Jun 1, 2023